You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/15 05:30:47 UTC
[GitHub] zihaolucky commented on a change in pull request #9083: Nceloss
zihaolucky commented on a change in pull request #9083: Nceloss
URL: https://github.com/apache/incubator-mxnet/pull/9083#discussion_r157126117
##########
File path: example/nce-loss/README.md
##########
@@ -54,28 +63,26 @@ The motivation is to design a more robust and scalable word vector system, by re
### Basics
-<img src="https://github.com/zihaolucky/mxnet/blob/example/word2vec-nce-loss-with-subword-representations/example/nce-loss-subword-repr/slide1.png" width="700">
+<img src="images/slide1.png" width="700">
-<img src="https://github.com/zihaolucky/mxnet/blob/example/word2vec-nce-loss-with-subword-representations/example/nce-loss-subword-repr/slide2.png" width="700">
+<img src="images/slide2.png" width="700">
Review comment:
Basically we don't put data like image into main source code, as that makes our code base too large.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services