You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2020/10/12 21:58:24 UTC
[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16585
Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile
......................................................................
IMPALA-10180: Add average size of fetch requests in runtime profile
When debugging slow fetch requests, it is useful to know the client
configured client size. This information is useful to see if the client
is fetching too few rows at a time. Currently, there is no way to figure
out the fetch size from the runtime profile, since it is often a client
side setting.
This patch adds a new summary stat called NumRowsFetchedPerRequest,
which tracks the min, max, and average size of the rows returned by
Impala per fetch request. Since the client can specify a different
number of rows to fetch per fetch request, a summary counter is
necessary.
Testing:
* Ran core tests
* Added new tests to test_fetch.py
Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
---
M be/src/service/client-request-state.cc
M be/src/service/client-request-state.h
M tests/query_test/test_fetch.py
3 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/16585/1
--
To view, visit http://gerrit.cloudera.org:8080/16585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
Gerrit-Change-Number: 16585
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16585 )
Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6582/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
Gerrit-Change-Number: 16585
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Oct 2020 17:05:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16585 )
Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6569/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
Gerrit-Change-Number: 16585
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 16:57:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16585 )
Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6548/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
Gerrit-Change-Number: 16585
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 21:58:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16585 )
Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6548/
--
To view, visit http://gerrit.cloudera.org:8080/16585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
Gerrit-Change-Number: 16585
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 03:23:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16585 )
Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile
......................................................................
Patch Set 1:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6569/
--
To view, visit http://gerrit.cloudera.org:8080/16585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
Gerrit-Change-Number: 16585
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 22:23:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16585 )
Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile
......................................................................
Patch Set 1:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6582/
--
To view, visit http://gerrit.cloudera.org:8080/16585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
Gerrit-Change-Number: 16585
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Oct 2020 17:50:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16585 )
Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7431/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
Gerrit-Change-Number: 16585
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 22:20:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10180: Add average size of fetch requests in runtime profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16585 )
Change subject: IMPALA-10180: Add average size of fetch requests in runtime profile
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16585/1/tests/query_test/test_fetch.py
File tests/query_test/test_fetch.py:
http://gerrit.cloudera.org:8080/#/c/16585/1/tests/query_test/test_fetch.py@81
PS1, Line 81: *
flake8: E226 missing whitespace around arithmetic operator
--
To view, visit http://gerrit.cloudera.org:8080/16585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf54e265e548c6fbca7b1ecfa8a1613ed3094e3f
Gerrit-Change-Number: 16585
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 21:59:09 +0000
Gerrit-HasComments: Yes