You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/09 14:55:18 UTC
[GitHub] [incubator-superset] kkucharc opened a new pull request #11214: test: datasource uid of cache in test_csv_response_format is asserted with table id
kkucharc opened a new pull request #11214:
URL: https://github.com/apache/incubator-superset/pull/11214
To be not depending on order of created tables, now assertion of cache's datasource uid is compared to table id of which it supposed be created.
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11214: test: datasource uid of cache in test_csv_response_format is asserted with table id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11214:
URL: https://github.com/apache/incubator-superset/pull/11214#issuecomment-706234724
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=h1) Report
> Merging [#11214](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **increase** coverage by `4.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11214 +/- ##
==========================================
+ Coverage 61.49% 65.67% +4.17%
==========================================
Files 828 828
Lines 39145 39148 +3
Branches 3589 3589
==========================================
+ Hits 24073 25711 +1638
+ Misses 14892 13326 -1566
+ Partials 180 111 -69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `56.10% <ø> (?)` | |
| #javascript | `62.30% <ø> (ø)` | |
| #python | `61.01% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvTGltaXRDb250cm9sLnRzeA==) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGF0YXNvdXJjZS9DaGFuZ2VEYXRhc291cmNlTW9kYWwudHN4) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaXN0Vmlldy9UYWJsZUNvbGxlY3Rpb24udHN4) | `100.00% <0.00%> (ø)` | |
| [...set/superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2FjdGlvbnMvc3FsTGFiLmpz) | `60.68% <0.00%> (+1.06%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvQWNlRWRpdG9yV3JhcHBlci50c3g=) | `60.75% <0.00%> (+1.26%)` | :arrow_up: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvZ3JpZENvbXBvbmVudHMvQ2hhcnRIb2xkZXIuanN4) | `79.16% <0.00%> (+1.38%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Db3B5VG9DbGlwYm9hcmQuanN4) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
| [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `92.30% <0.00%> (+1.53%)` | :arrow_up: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvcmVzaXphYmxlL1Jlc2l6YWJsZUNvbnRhaW5lci5qc3g=) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlld3MvQ1JVRC9kYXRhL2RhdGFzZXQvRGF0YXNldExpc3QudHN4) | `72.80% <0.00%> (+1.59%)` | :arrow_up: |
| ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=footer). Last update [761e6db...19dbbcf](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11214: test: datasource uid of cache in test_csv_response_format is asserted with table id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11214:
URL: https://github.com/apache/incubator-superset/pull/11214#issuecomment-706234724
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=h1) Report
> Merging [#11214](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11214 +/- ##
==========================================
- Coverage 61.49% 61.48% -0.01%
==========================================
Files 828 828
Lines 39145 39145
Branches 3589 3589
==========================================
- Hits 24073 24070 -3
- Misses 14892 14895 +3
Partials 180 180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (ø)` | |
| #python | `61.00% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.42% <0.00%> (-0.65%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=footer). Last update [761e6db...19dbbcf](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11214: test: datasource uid of cache in test_csv_response_format is asserted with table id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11214:
URL: https://github.com/apache/incubator-superset/pull/11214#issuecomment-706234724
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=h1) Report
> Merging [#11214](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **decrease** coverage by `0.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11214 +/- ##
==========================================
- Coverage 61.49% 61.07% -0.43%
==========================================
Files 828 828
Lines 39145 39145
Branches 3589 3589
==========================================
- Hits 24073 23906 -167
- Misses 14892 15059 +167
Partials 180 180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (ø)` | |
| #python | `60.33% <ø> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.56% <0.00%> (-0.83%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=footer). Last update [761e6db...19dbbcf](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11214: test: datasource uid of cache in test_csv_response_format is asserted with table id
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11214:
URL: https://github.com/apache/incubator-superset/pull/11214#issuecomment-706234724
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=h1) Report
> Merging [#11214](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **decrease** coverage by `1.53%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11214 +/- ##
==========================================
- Coverage 61.49% 59.95% -1.54%
==========================================
Files 828 392 -436
Lines 39145 24544 -14601
Branches 3589 0 -3589
==========================================
- Hits 24073 14716 -9357
+ Misses 14892 9828 -5064
+ Partials 180 0 -180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `59.95% <ø> (-1.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=footer). Last update [761e6db...19dbbcf](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11214: test: datasource uid of cache in test_csv_response_format is asserted with table id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11214:
URL: https://github.com/apache/incubator-superset/pull/11214#issuecomment-706234724
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=h1) Report
> Merging [#11214](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11214 +/- ##
=======================================
Coverage 61.49% 61.49%
=======================================
Files 828 828
Lines 39145 39145
Branches 3589 3589
=======================================
Hits 24073 24073
Misses 14892 14892
Partials 180 180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (ø)` | |
| #python | `61.01% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=footer). Last update [761e6db...19dbbcf](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett merged pull request #11214: test: datasource uid of cache in test_csv_response_format is asserted with table id
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #11214:
URL: https://github.com/apache/incubator-superset/pull/11214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11214: test: datasource uid of cache in test_csv_response_format is asserted with table id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11214:
URL: https://github.com/apache/incubator-superset/pull/11214#issuecomment-706234724
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=h1) Report
> Merging [#11214](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11214 +/- ##
==========================================
- Coverage 61.49% 61.38% -0.12%
==========================================
Files 828 828
Lines 39145 39145
Branches 3589 3589
==========================================
- Hits 24073 24028 -45
- Misses 14892 14937 +45
Partials 180 180
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (ø)` | |
| #python | `60.83% <ø> (-0.19%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.12% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.70% <0.00%> (-0.14%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=footer). Last update [761e6db...19dbbcf](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11214: test: datasource uid of cache in test_csv_response_format is asserted with table id
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11214:
URL: https://github.com/apache/incubator-superset/pull/11214#issuecomment-706234724
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=h1) Report
> Merging [#11214](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/761e6dbf524acb1398d41297834a07430f21a050?el=desc) will **increase** coverage by `4.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11214 +/- ##
==========================================
+ Coverage 61.49% 65.59% +4.10%
==========================================
Files 828 828
Lines 39145 39148 +3
Branches 3589 3589
==========================================
+ Hits 24073 25681 +1608
+ Misses 14892 13355 -1537
+ Partials 180 112 -68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.45% <ø> (?)` | |
| #javascript | `62.30% <ø> (ø)` | |
| #python | `61.01% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvTGltaXRDb250cm9sLnRzeA==) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGF0YXNvdXJjZS9DaGFuZ2VEYXRhc291cmNlTW9kYWwudHN4) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaXN0Vmlldy9UYWJsZUNvbGxlY3Rpb24udHN4) | `100.00% <0.00%> (ø)` | |
| [...set/superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2FjdGlvbnMvc3FsTGFiLmpz) | `60.25% <0.00%> (+0.64%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU3FsRWRpdG9yLmpzeA==) | `52.12% <0.00%> (+1.21%)` | :arrow_up: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvZ3JpZENvbXBvbmVudHMvQ2hhcnRIb2xkZXIuanN4) | `79.16% <0.00%> (+1.38%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Db3B5VG9DbGlwYm9hcmQuanN4) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
| [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `92.30% <0.00%> (+1.53%)` | :arrow_up: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvcmVzaXphYmxlL1Jlc2l6YWJsZUNvbnRhaW5lci5qc3g=) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlld3MvQ1JVRC9kYXRhL2RhdGFzZXQvRGF0YXNldExpc3QudHN4) | `72.80% <0.00%> (+1.59%)` | :arrow_up: |
| ... and [163 more](https://codecov.io/gh/apache/incubator-superset/pull/11214/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=footer). Last update [761e6db...19dbbcf](https://codecov.io/gh/apache/incubator-superset/pull/11214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org