You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/05/11 06:53:12 UTC

Review Request 34027: DRILL-3019: Extra column in Schema of Recordbatch from scanning Values

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34027/
-----------------------------------------------------------

Review request for drill and Jacques Nadeau.


Bugs: DRILL-3019
    https://issues.apache.org/jira/browse/DRILL-3019


Repository: drill-git


Description
-------

In JsonReader, update atLeastOneWrite to true if writeListDataIfTyped and writeMapDataIfTyped write a value


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java 095d8c6 

Diff: https://reviews.apache.org/r/34027/diff/


Testing
-------

Unit, Functional, tpch all passed


Thanks,

Sean Hsuan-Yi Chu


Re: Review Request 34027: DRILL-3019: Extra column in Schema of Recordbatch from scanning Values

Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34027/
-----------------------------------------------------------

(Updated May 11, 2015, 9:45 p.m.)


Review request for drill and Jacques Nadeau.


Changes
-------

A new patch which updates to the r6 drill-calcite and adds one test case. Unit test passed; Others are waiting in the line.


Bugs: DRILL-3019
    https://issues.apache.org/jira/browse/DRILL-3019


Repository: drill-git


Description
-------

In JsonReader, update atLeastOneWrite to true if writeListDataIfTyped and writeMapDataIfTyped write a value


Diffs (updated)
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java 095d8c6 
  exec/java-exec/src/test/java/org/apache/drill/TestInListConstructedByUnionAll.java PRE-CREATION 
  pom.xml 6344306 

Diff: https://reviews.apache.org/r/34027/diff/


Testing
-------

Unit, Functional, tpch all passed


Thanks,

Sean Hsuan-Yi Chu