You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2011/09/06 13:46:54 UTC

svn commit: r1165615 - in /httpcomponents/httpasyncclient/trunk: RELEASE_NOTES.txt httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java

Author: olegk
Date: Tue Sep  6 11:46:54 2011
New Revision: 1165615

URL: http://svn.apache.org/viewvc?rev=1165615&view=rev
Log:
HTTPASYNC-6: Fixed NPE in the DefaultAsyncRequestDirector#responseCompleted method

Modified:
    httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt
    httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java

Modified: httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt?rev=1165615&r1=1165614&r2=1165615&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt (original)
+++ httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt Tue Sep  6 11:46:54 2011
@@ -1,3 +1,10 @@
+Changes since 4.0 Alpha 2
+-------------------
+
+* [HTTPASYNC-6]: Fixed NPE in the DefaultAsyncRequestDirector#responseCompleted method.
+  Contributed by Oleg Kalnichevski <olegk at apache.org>
+
+
 Release 4.0 Alpha 2
 -------------------
 

Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java?rev=1165615&r1=1165614&r2=1165615&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java (original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/DefaultAsyncRequestDirector.java Tue Sep  6 11:46:54 2011
@@ -363,6 +363,9 @@ class DefaultAsyncRequestDirector<T> imp
     public synchronized void responseCompleted() {
         this.log.debug("Response fully read");
         try {
+            if (this.resultCallback.isDone()) {
+                return;
+            }
             if (this.managedConn.isOpen()) {
                 long duration = this.keepaliveStrategy.getKeepAliveDuration(
                         this.currentResponse, this.localContext);