You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/30 08:23:28 UTC
[GitHub] [incubator-mxnet] ciyongch opened a new pull request #19047: Update NEWS, README and website for 1.7.0
ciyongch opened a new pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047
Update NEWS README and website for 1.7.0 release.
@szha @TaoLv @leezu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on a change in pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#discussion_r480827975
##########
File path: NEWS.md
##########
@@ -18,120 +18,161 @@
MXNet Change Log
================
- [MXNet Change Log](#mxnet-change-log)
- * [1.6.0](#160)
- + [Deprecation of Python 2](#deprecation-of-python-2)
- + [New Features](#new-features)
- - [NumPy compatible interface and using TVM to generate operators](#numpy-compatible-interface-and-using-tvm-to-generate-operators)
- - [Graph optimizations](#graph-optimizations)
+ - [1.7.0](#170)
+ - [New features](#new-features)
+ - [MXNet Extensions: custom operators, partitioning, and graph passes](#mxnet-extensions-custom-operators-partitioning-and-graph-passes)
+ - [OpPerf utility enabled in the binary distribution](#opperf-utility-enabled-in-the-binary-distribution)
Review comment:
which PR did this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#issuecomment-683391809
Hey @ciyongch , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, centos-gpu, miscellaneous, windows-cpu, unix-gpu, windows-gpu, edge, clang, website, sanity, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TaoLv commented on pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
TaoLv commented on pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#issuecomment-683429724
It's strange. I remember I changed the download table to use mirror links in https://github.com/apache/incubator-mxnet/pull/16501.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#discussion_r482529334
##########
File path: docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
##########
@@ -9,17 +9,28 @@ page](https://mxnet.apache.org/get_started/download).
Run the following command:
-<div class="v1-6-0">
+<div class="v1-7-0">
{% highlight bash %}
pip install mxnet
{% endhighlight %}
+Start from 1.7.0 release, MKL-DNN is enabled in pip packages by default. Which are
+optimized for Intel hardware. You can find performance numbers
Review comment:
yes it's WIP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
ciyongch commented on a change in pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#discussion_r480922983
##########
File path: NEWS.md
##########
@@ -18,120 +18,161 @@
MXNet Change Log
================
- [MXNet Change Log](#mxnet-change-log)
- * [1.6.0](#160)
- + [Deprecation of Python 2](#deprecation-of-python-2)
- + [New Features](#new-features)
- - [NumPy compatible interface and using TVM to generate operators](#numpy-compatible-interface-and-using-tvm-to-generate-operators)
- - [Graph optimizations](#graph-optimizations)
+ - [1.7.0](#170)
+ - [New features](#new-features)
+ - [MXNet Extensions: custom operators, partitioning, and graph passes](#mxnet-extensions-custom-operators-partitioning-and-graph-passes)
+ - [OpPerf utility enabled in the binary distribution](#opperf-utility-enabled-in-the-binary-distribution)
Review comment:
Hi @ChaiBapchya , probably it's not drived by any PR in the current scope, but included in the binary release process. cc @szha to see if any comments.
When trying to install mxnet release (1.7.0) wheel via pip, the benchmark/opperf is also installed now. And the original proposal from you is listed in [1.7.0 roadmap](https://github.com/apache/incubator-mxnet/issues/16864#issuecomment-585461851)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#discussion_r481344317
##########
File path: docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
##########
@@ -9,17 +9,28 @@ page](https://mxnet.apache.org/get_started/download).
Run the following command:
-<div class="v1-6-0">
+<div class="v1-7-0">
{% highlight bash %}
pip install mxnet
{% endhighlight %}
+Start from 1.7.0 release, MKL-DNN is enabled in pip packages by default. Which are
+optimized for Intel hardware. You can find performance numbers
+in the <a href="https://mxnet.io/api/faq/perf#intel-cpu">MXNet tuning guide</a>.
Review comment:
Link to mxnet.apache.org/
##########
File path: docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
##########
@@ -9,17 +9,28 @@ page](https://mxnet.apache.org/get_started/download).
Run the following command:
-<div class="v1-6-0">
+<div class="v1-7-0">
{% highlight bash %}
pip install mxnet
{% endhighlight %}
+Start from 1.7.0 release, MKL-DNN is enabled in pip packages by default. Which are
+optimized for Intel hardware. You can find performance numbers
Review comment:
Elaborate on the "optimization? For example "oneAPI Deep Neural Network Library (oneDNN) is an open-source cross-platform performance library of basic building blocks for deep learning applications. The library is optimized for Intel Architecture Processors, Intel Processor Graphics and Xe architecture-based Graphics. Support for other architectures such as Arm* 64-bit Architecture (AArch64) and OpenPOWER* Power ISA (PPC64) is experimental." (from the oneDNN repo).
Please mention that the `mxnet-native` release is available which does come without oneDNN
##########
File path: docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
##########
@@ -9,17 +9,28 @@ page](https://mxnet.apache.org/get_started/download).
Run the following command:
-<div class="v1-6-0">
+<div class="v1-7-0">
{% highlight bash %}
pip install mxnet
{% endhighlight %}
+Start from 1.7.0 release, MKL-DNN is enabled in pip packages by default. Which are
Review comment:
oneDNN?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
ciyongch commented on a change in pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#discussion_r481536978
##########
File path: docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
##########
@@ -9,17 +9,28 @@ page](https://mxnet.apache.org/get_started/download).
Run the following command:
-<div class="v1-6-0">
+<div class="v1-7-0">
{% highlight bash %}
pip install mxnet
{% endhighlight %}
+Start from 1.7.0 release, MKL-DNN is enabled in pip packages by default. Which are
+optimized for Intel hardware. You can find performance numbers
Review comment:
Thank you for the valuable inputs, leezu, I will update the description here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#issuecomment-683512421
> Must use archive.apache.org for all but the latest release. See https://infra.apache.org/release-publishing.html
Sure, I will update the download link according to this spec. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#issuecomment-684518554
Hi @leezu @szha @marcoabreu @ChaiBapchya @TaoLv @pengzhao-intel , please help to take a review and comment if anything needs to be updated, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#issuecomment-683512261
> It's strange. I remember I changed the download table to use mirror links in #16501.
They're changed by #18487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#issuecomment-685416343
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
ciyongch commented on a change in pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#discussion_r481600274
##########
File path: docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
##########
@@ -9,17 +9,28 @@ page](https://mxnet.apache.org/get_started/download).
Run the following command:
-<div class="v1-6-0">
+<div class="v1-7-0">
{% highlight bash %}
pip install mxnet
{% endhighlight %}
+Start from 1.7.0 release, MKL-DNN is enabled in pip packages by default. Which are
+optimized for Intel hardware. You can find performance numbers
Review comment:
BTW, I didn't find available `mxnet-native` pip wheel via `pip install mxnet-native`, is it still WIP or using the different name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
ciyongch commented on a change in pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#discussion_r481621982
##########
File path: docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
##########
@@ -9,17 +9,28 @@ page](https://mxnet.apache.org/get_started/download).
Run the following command:
-<div class="v1-6-0">
+<div class="v1-7-0">
{% highlight bash %}
pip install mxnet
{% endhighlight %}
+Start from 1.7.0 release, MKL-DNN is enabled in pip packages by default. Which are
+optimized for Intel hardware. You can find performance numbers
+in the <a href="https://mxnet.io/api/faq/perf#intel-cpu">MXNet tuning guide</a>.
Review comment:
The perf link under mxnet.apache.org will contain the version number like "https://mxnet.apache.org/versions/1.6/api/faq/perf.html#intel-cpu". Is there any basic link without version number which can redirect to the latest version of the page?
Please check my latest update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19047: Update NEWS, README and website for 1.7.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19047:
URL: https://github.com/apache/incubator-mxnet/pull/19047#issuecomment-685416408
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org