You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/02/19 11:26:26 UTC

[GitHub] cordova-plugin-splashscreen pull request: CB-10636 CB-10650 Add JS...

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/84

    CB-10636 CB-10650 Add JSHint for plugins

    [CB-10636 Add JSHint for plugins](https://issues.apache.org/jira/browse/CB-10636)
    [CB-10650 Non-index content.src causes Splashscreen to be not displayed on browser](https://issues.apache.org/jira/browse/CB-10650)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-splashscreen CB-10636

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit 5ea854d8c3671751778a67095b3ec36a55e0c71b
Author: daserge <v-...@microsoft.com>
Date:   2016-02-19T09:04:40Z

    CB-10636 Add JSHint for plugins
    
    Fixed autotests

commit c77e8e013ce99fd9b821eb7abb95fd65995e55c1
Author: daserge <v-...@microsoft.com>
Date:   2016-02-19T09:46:29Z

    CB-10650 Non-index content.src causes Splashscreen to be not displayed on browser

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-splashscreen pull request: CB-10636 CB-10650 Add JS...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/84


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-splashscreen pull request: CB-10636 CB-10650 Add JS...

Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/84#issuecomment-188148446
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-splashscreen pull request: CB-10636 CB-10650 Add JS...

Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/84#issuecomment-186160148
  
    Associated with PR https://github.com/apache/cordova-browser/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org