[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37490: [SPARK-40051][PYTHON][SQL][DOCS] Make pyspark.sql.catalog examples self-contained

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #37490:
URL: https://github.com/apache/spark/pull/37490#discussion_r944145436


##########
python/pyspark/sql/catalog.py:
##########
@@ -123,19 +132,52 @@ def listCatalogs(self) -> List[CatalogMetadata]:
             catalogs.append(CatalogMetadata(name=jcatalog.name, description=jcatalog.description))
         return catalogs
 
-    @since(2.0)

Review Comment:
   Because it breaks the docstring format. `since` adds the `versionadded` directive at the end of docstring which does not work in NumPy documentation style when `Parameters`, etc are specified. We should remove these all eventually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org