[GitHub] [incubator-iceberg] waterlx edited a comment on issue #279: Transforming timestamp to date should produce date

[GitBox <gi...@apache.org>]

waterlx edited a comment on issue #279: Transforming timestamp to date should produce date
URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-521086258
 
 
   @rdblue, regarding
   > @manishmalhotrawork, only the `day` transform should return a date. Years, months, and hours should continue returning ordinals like before.
   
   so you mean that we are supposed to keep `org.apache.iceberg.transforms.Timestamps` as it is (as `Transform<Long, Integer>`) and keep `org.apache.iceberg.transforms.Dates` as it is (as `Transform<Integer, Integer>`), so as not to change the return of `Transforms.year(), month() and hour()`? Do you propose to only change the output of Transforms.day() to `Transform<T, Date>`? Do I get it right?
   
   @manishmalhotrawork yes, I am working on this issue. But please feel free to go ahead to share your thoughts or upload patches, I am new to iceberg 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org