You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by bo...@apache.org on 2026/06/22 18:12:15 UTC
(grails-core) 08/12: Revert SortedSet/Comparable additions in CompositeIdWithJoinTableSpec
This is an automated email from the ASF dual-hosted git repository.
borinquenkid pushed a commit to branch 8.0.x-hibernate7
in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit f576f9bd8127781169dad0a4e51559b90873c4f2
Author: Walter Duque de Estrada <wb...@mac.com>
AuthorDate: Mon Jun 22 12:22:53 2026 -0500
Revert SortedSet/Comparable additions in CompositeIdWithJoinTableSpec
Both were introduced during a merge commit without a stated reason. The
8.0.x baseline uses the implicit Set from hasMany and CompositeIdChild
does not implement Comparable. The test only checks size, not order.
Co-Authored-By: Claude Sonnet 4.6 <no...@anthropic.com>
---
.../groovy/grails/gorm/tests/CompositeIdWithJoinTableSpec.groovy | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/grails-data-hibernate5/core/src/test/groovy/grails/gorm/tests/CompositeIdWithJoinTableSpec.groovy b/grails-data-hibernate5/core/src/test/groovy/grails/gorm/tests/CompositeIdWithJoinTableSpec.groovy
index 325722ad28..acf7cd0ed3 100644
--- a/grails-data-hibernate5/core/src/test/groovy/grails/gorm/tests/CompositeIdWithJoinTableSpec.groovy
+++ b/grails-data-hibernate5/core/src/test/groovy/grails/gorm/tests/CompositeIdWithJoinTableSpec.groovy
@@ -48,7 +48,6 @@ class CompositeIdWithJoinTableSpec extends HibernateGormDatastoreSpec {
class CompositeIdParent implements Serializable, Comparable<CompositeIdParent> {
String name
String last
- SortedSet<CompositeIdChild> children
static hasMany = [children: CompositeIdChild]
static mapping = define {
id composite('name', 'last')
@@ -73,7 +72,7 @@ class CompositeIdParent implements Serializable, Comparable<CompositeIdParent> {
}
@Entity
-class CompositeIdChild implements Comparable<CompositeIdChild> {
+class CompositeIdChild {
String foo
static belongsTo = [parent: CompositeIdParent]
@@ -82,9 +81,4 @@ class CompositeIdChild implements Comparable<CompositeIdChild> {
}
static constraints = {
}
-
- @Override
- int compareTo(CompositeIdChild other) {
- foo <=> other.foo
- }
}