You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by im...@apache.org on 2008/04/07 20:31:08 UTC

svn commit: r645640 - /myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/requestParameterProvider/RequestParameterProviderManager.java

Author: imario
Date: Mon Apr  7 11:31:07 2008
New Revision: 645640

URL: http://svn.apache.org/viewvc?rev=645640&view=rev
Log:
changed NPE check

Modified:
    myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/requestParameterProvider/RequestParameterProviderManager.java

Modified: myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/requestParameterProvider/RequestParameterProviderManager.java
URL: http://svn.apache.org/viewvc/myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/requestParameterProvider/RequestParameterProviderManager.java?rev=645640&r1=645639&r2=645640&view=diff
==============================================================================
--- myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/requestParameterProvider/RequestParameterProviderManager.java (original)
+++ myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/requestParameterProvider/RequestParameterProviderManager.java Mon Apr  7 11:31:07 2008
@@ -116,6 +116,11 @@
             throw new IllegalStateException("RequestParameterServletFilter not called. Please configure the filter " + RequestParameterServletFilter.class.getName() + " in your web.xml to cover your faces requests.");
         }
 
+        if (url == null)
+        {
+            return null;
+        }
+
         if (PAGE_LINK_SEP.equals(url))
         {
             // just an inner page link, ignore
@@ -130,11 +135,6 @@
         }
 
         StringBuffer sb = new StringBuffer();
-        if (url == null)
-        {
-            LOG.warn("URL is null -> empty string is returned.");
-            return sb.toString();
-        }
 
         int nuofParams = -1;
         String firstSeparator = url.indexOf(PAGE_PARAMETER_SEP) == -1 ? PAGE_PARAMETER_SEP : PARAMETER_SEP;