You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/10/29 10:29:19 UTC
Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/
-----------------------------------------------------------
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-4908
https://issues.apache.org/jira/browse/CLOUDSTACK-4908
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4908: CPU socket count of host
Adding cpu socket count of the host in hostresponse
Diffs
-----
api/src/com/cloud/host/Host.java 17b0ba8
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
engine/schema/src/com/cloud/host/HostVO.java c814b94
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 286d0f7
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 6c1efe7
server/src/com/cloud/api/query/QueryManagerImpl.java a7d85cf
server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
setup/db/db/schema-421to430.sql 0e78875
vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
Diff: https://reviews.apache.org/r/15018/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On Nov. 4, 2013, 10:48 a.m., Koushik Das wrote:
> > api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java, line 92
> > <https://reviews.apache.org/r/15018/diff/2/?file=374631#file374631line92>
> >
> > Why is this change required for CPU sockets?
We want to show the cpu sockets per hypervisor, but currently we dont have filter on hypervisor host type. This will add that filter.
> On Nov. 4, 2013, 10:48 a.m., Koushik Das wrote:
> > core/src/com/cloud/agent/api/StartupRoutingCommand.java, line 45
> > <https://reviews.apache.org/r/15018/diff/2/?file=374633#file374633line45>
> >
> > Why Integer and not int?
In some hypervisors cpusockets cannot be retrieved so it can be null in those cases.
> On Nov. 4, 2013, 10:48 a.m., Koushik Das wrote:
> > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java, line 8076
> > <https://reviews.apache.org/r/15018/diff/2/?file=374639#file374639line8076>
> >
> > Why Integer? Can this be null?
In some hypervisors cpusockets cannot be retrieved so it can be null in those cases.
> On Nov. 4, 2013, 10:48 a.m., Koushik Das wrote:
> > server/src/com/cloud/api/query/QueryManagerImpl.java, line 1549
> > <https://reviews.apache.org/r/15018/diff/2/?file=374640#file374640line1549>
> >
> > This change doesn't look related
This is included to add filter based on hypervisor host type.(Xenserver, vmware, kvm, Hyperv, Lxc)
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/#review28094
-----------------------------------------------------------
On Nov. 5, 2013, 9:23 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15018/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 9:23 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4908
> https://issues.apache.org/jira/browse/CLOUDSTACK-4908
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4908: CPU socket count of host
> Adding cpu socket count of the host in hostresponse
>
>
> Diffs
> -----
>
> api/src/com/cloud/host/Host.java 17b0ba8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
> api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
> core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
> core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
> engine/schema/src/com/cloud/host/HostVO.java c814b94
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8d3a0e9
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3323a15
> server/src/com/cloud/api/query/QueryManagerImpl.java 51ee249
> server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
> server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
> server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
> setup/db/db/schema-421to430.sql 803f1d9
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
>
> Diff: https://reviews.apache.org/r/15018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/#review28094
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java
<https://reviews.apache.org/r/15018/#comment54677>
Why is this change required for CPU sockets?
core/src/com/cloud/agent/api/StartupRoutingCommand.java
<https://reviews.apache.org/r/15018/#comment54678>
Why Integer and not int?
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/15018/#comment54679>
Why Integer? Can this be null?
server/src/com/cloud/api/query/QueryManagerImpl.java
<https://reviews.apache.org/r/15018/#comment54680>
This change doesn't look related
setup/db/db/schema-421to430.sql
<https://reviews.apache.org/r/15018/#comment54681>
Simply drop and recreate the view
- Koushik Das
On Oct. 31, 2013, 10:14 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15018/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 10:14 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4908
> https://issues.apache.org/jira/browse/CLOUDSTACK-4908
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4908: CPU socket count of host
> Adding cpu socket count of the host in hostresponse
>
>
> Diffs
> -----
>
> api/src/com/cloud/host/Host.java 17b0ba8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
> api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
> core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
> core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
> engine/schema/src/com/cloud/host/HostVO.java c814b94
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8d3a0e9
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3323a15
> server/src/com/cloud/api/query/QueryManagerImpl.java 51ee249
> server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
> server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
> server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
> setup/db/db/schema-421to430.sql 803f1d9
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
>
> Diff: https://reviews.apache.org/r/15018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/#review28156
-----------------------------------------------------------
Commit 57678257a123da1f74fa2a81407beb94450444b3 in branch refs/heads/master from Jessica Wang
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5767825 ]
CLOUDSTACK-4908: UI > Infrastructure > Sockets > view all > calculate Hosts for each hypervisor.
- ASF Subversion and Git Services
On Oct. 31, 2013, 10:14 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15018/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 10:14 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4908
> https://issues.apache.org/jira/browse/CLOUDSTACK-4908
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4908: CPU socket count of host
> Adding cpu socket count of the host in hostresponse
>
>
> Diffs
> -----
>
> api/src/com/cloud/host/Host.java 17b0ba8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
> api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
> core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
> core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
> engine/schema/src/com/cloud/host/HostVO.java c814b94
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8d3a0e9
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3323a15
> server/src/com/cloud/api/query/QueryManagerImpl.java 51ee249
> server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
> server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
> server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
> setup/db/db/schema-421to430.sql 803f1d9
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
>
> Diff: https://reviews.apache.org/r/15018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/#review28183
-----------------------------------------------------------
Ship it!
Ship It!
- Koushik Das
On Nov. 5, 2013, 10:34 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15018/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 10:34 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4908
> https://issues.apache.org/jira/browse/CLOUDSTACK-4908
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4908: CPU socket count of host
> Adding cpu socket count of the host in hostresponse
>
>
> Diffs
> -----
>
> api/src/com/cloud/host/Host.java 17b0ba8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
> api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
> core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
> core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
> engine/schema/src/com/cloud/host/HostVO.java c814b94
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java e3f60f2
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java f6f84f6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java ccb27ea
> server/src/com/cloud/api/query/QueryManagerImpl.java 735bbc9
> server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
> server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
> server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
> setup/db/db/schema-421to430.sql 1c99e3f
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
>
> Diff: https://reviews.apache.org/r/15018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/#review28182
-----------------------------------------------------------
Commit a286dec098ec9fe663c2bbead128f88bf9f18418 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a286dec ]
CLOUDSTACK-4908: CPU socket count of host Adding cpu socket count of the host in hostresponse
Signed-off-by: Koushik Das <ko...@apache.org>
- ASF Subversion and Git Services
On Nov. 5, 2013, 10:34 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15018/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 10:34 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4908
> https://issues.apache.org/jira/browse/CLOUDSTACK-4908
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4908: CPU socket count of host
> Adding cpu socket count of the host in hostresponse
>
>
> Diffs
> -----
>
> api/src/com/cloud/host/Host.java 17b0ba8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
> api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
> core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
> core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
> engine/schema/src/com/cloud/host/HostVO.java c814b94
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java e3f60f2
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java f6f84f6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java ccb27ea
> server/src/com/cloud/api/query/QueryManagerImpl.java 735bbc9
> server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
> server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
> server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
> setup/db/db/schema-421to430.sql 1c99e3f
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
>
> Diff: https://reviews.apache.org/r/15018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/#review28210
-----------------------------------------------------------
Commit c61d2eedf4a87107ae9a77c8c39b7f584995e617 in branch refs/heads/master from Jessica Wang
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c61d2ee ]
CLOUDSTACK-4908: UI > Infrastructure > Sockets > (1) calculate total number of CPU Sockets for all hypervisors.
(2) > view all > calculate CPU Sockets for each hypervisor.
- ASF Subversion and Git Services
On Nov. 5, 2013, 10:34 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15018/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 10:34 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4908
> https://issues.apache.org/jira/browse/CLOUDSTACK-4908
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4908: CPU socket count of host
> Adding cpu socket count of the host in hostresponse
>
>
> Diffs
> -----
>
> api/src/com/cloud/host/Host.java 17b0ba8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
> api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
> core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
> core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
> engine/schema/src/com/cloud/host/HostVO.java c814b94
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java e3f60f2
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java f6f84f6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java ccb27ea
> server/src/com/cloud/api/query/QueryManagerImpl.java 735bbc9
> server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
> server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
> server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
> setup/db/db/schema-421to430.sql 1c99e3f
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
>
> Diff: https://reviews.apache.org/r/15018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/
-----------------------------------------------------------
(Updated Nov. 5, 2013, 10:34 a.m.)
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-4908
https://issues.apache.org/jira/browse/CLOUDSTACK-4908
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4908: CPU socket count of host
Adding cpu socket count of the host in hostresponse
Diffs (updated)
-----
api/src/com/cloud/host/Host.java 17b0ba8
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
engine/schema/src/com/cloud/host/HostVO.java c814b94
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java e3f60f2
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java f6f84f6
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java ccb27ea
server/src/com/cloud/api/query/QueryManagerImpl.java 735bbc9
server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
setup/db/db/schema-421to430.sql 1c99e3f
vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
Diff: https://reviews.apache.org/r/15018/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/
-----------------------------------------------------------
(Updated Nov. 5, 2013, 9:36 a.m.)
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-4908
https://issues.apache.org/jira/browse/CLOUDSTACK-4908
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4908: CPU socket count of host
Adding cpu socket count of the host in hostresponse
Diffs (updated)
-----
api/src/com/cloud/host/Host.java 17b0ba8
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
engine/schema/src/com/cloud/host/HostVO.java c814b94
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8d3a0e9
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3323a15
server/src/com/cloud/api/query/QueryManagerImpl.java 51ee249
server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
setup/db/db/schema-421to430.sql 803f1d9
vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
Diff: https://reviews.apache.org/r/15018/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/
-----------------------------------------------------------
(Updated Nov. 5, 2013, 9:23 a.m.)
Review request for cloudstack and Kishan Kavala.
Changes
-------
Updated patch with related tests and based on review comments on view creation.
Bugs: CLOUDSTACK-4908
https://issues.apache.org/jira/browse/CLOUDSTACK-4908
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4908: CPU socket count of host
Adding cpu socket count of the host in hostresponse
Diffs (updated)
-----
api/src/com/cloud/host/Host.java 17b0ba8
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
engine/schema/src/com/cloud/host/HostVO.java c814b94
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8d3a0e9
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3323a15
server/src/com/cloud/api/query/QueryManagerImpl.java 51ee249
server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
setup/db/db/schema-421to430.sql 803f1d9
vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
Diff: https://reviews.apache.org/r/15018/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/
-----------------------------------------------------------
(Updated Oct. 31, 2013, 10:14 a.m.)
Review request for cloudstack and Kishan Kavala.
Changes
-------
updated patch after resolving conflicts with latest master.
Bugs: CLOUDSTACK-4908
https://issues.apache.org/jira/browse/CLOUDSTACK-4908
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4908: CPU socket count of host
Adding cpu socket count of the host in hostresponse
Diffs (updated)
-----
api/src/com/cloud/host/Host.java 17b0ba8
api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
engine/schema/src/com/cloud/host/HostVO.java c814b94
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 8d3a0e9
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 3323a15
server/src/com/cloud/api/query/QueryManagerImpl.java 51ee249
server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
setup/db/db/schema-421to430.sql 803f1d9
vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
Diff: https://reviews.apache.org/r/15018/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 15018: CLOUDSTACK-4908: CPU socket count of host
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15018/#review27731
-----------------------------------------------------------
Commit bed42deb8835760e98a39902a698c38dbd17b414 in branch refs/heads/master from Brian Federle
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bed42de ]
CLOUDSTACK-4908: UI for report CPU sockets
-Adds socket info for hypervisors on infrastructure chart
-Displays # of sockets, and # of hosts
-Currently only dummy data set to 0 for all info
- ASF Subversion and Git Services
On Oct. 29, 2013, 9:29 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15018/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 9:29 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4908
> https://issues.apache.org/jira/browse/CLOUDSTACK-4908
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4908: CPU socket count of host
> Adding cpu socket count of the host in hostresponse
>
>
> Diffs
> -----
>
> api/src/com/cloud/host/Host.java 17b0ba8
> api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java 95b9ac3
> api/src/org/apache/cloudstack/api/response/HostResponse.java 687687d
> core/src/com/cloud/agent/api/StartupRoutingCommand.java d52666b
> core/test/org/apache/cloudstack/api/agent/test/CheckOnHostCommandTest.java 1b68276
> engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java 249c2db
> engine/schema/src/com/cloud/host/HostVO.java c814b94
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 286d0f7
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 423abe6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 6c1efe7
> server/src/com/cloud/api/query/QueryManagerImpl.java a7d85cf
> server/src/com/cloud/api/query/dao/HostJoinDaoImpl.java 97f8bf9
> server/src/com/cloud/api/query/vo/HostJoinVO.java fbc59cd
> server/src/com/cloud/resource/ResourceManagerImpl.java e9d5193
> setup/db/db/schema-421to430.sql 0e78875
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 108a3ec
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java f7288f1
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHostResourceSummary.java fa11dc3
>
> Diff: https://reviews.apache.org/r/15018/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>