You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/06/18 03:23:44 UTC

Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35586/
-----------------------------------------------------------

Review request for mesos and Niklas Nielsen.


Bugs: MESOS-2884
    https://issues.apache.org/jira/browse/MESOS-2884


Repository: mesos


Description
-------

MesosContainerizer looks up the list of required namespaces by calling
Isolator::namespaces() for all enabled isolators and passes on this
value to LinuxLauncher.


Diffs
-----

  src/slave/containerizer/linux_launcher.hpp ec08e24b9ba525893d218636ebddea480e641bbf 
  src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 
  src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 
  src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 

Diff: https://reviews.apache.org/r/35586/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35586/#review88331
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35585, 35586]

All tests passed.

- Mesos ReviewBot


On June 18, 2015, 1:23 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35586/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 1:23 a.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Bugs: MESOS-2884
>     https://issues.apache.org/jira/browse/MESOS-2884
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MesosContainerizer looks up the list of required namespaces by calling
> Isolator::namespaces() for all enabled isolators and passes on this
> value to LinuxLauncher.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.hpp ec08e24b9ba525893d218636ebddea480e641bbf 
>   src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 
>   src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 
>   src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 
> 
> Diff: https://reviews.apache.org/r/35586/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>