You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/22 23:10:38 UTC

[GitHub] [netbeans] lkishalmi opened a new pull request, #4845: Upgrade ANTLRv4 Runtime to 4.11.1

lkishalmi opened a new pull request, #4845:
URL: https://github.com/apache/netbeans/pull/4845

   Well this one is an interesting one. ANTLRv4 4.10 broke it's backward compatibility, so Parsers built with previous ANTLRv4 versions are no longer work with ANTLRv4 4.10+ runtimes, the Parsers needs to be re-generated with the newer tool.
   
   I've checked our repository, before the recent addition of TOML and ANTLR grammars we have a Json grammar which needs to be rebuilt. (That's the second commit.) That module is friendly used some other places. The module is exporting the generated Laxer/Parser, the sigcheck fails, so in this commit the signature file is missing. Though at first test the source is compatible.
   
   BTW, the whole upgrade story is originated from, that the TOML java library which is used for the TOML support, just got upgraded for the official TOML 1.0.0 specs. I wished if I just could update the library and put it in delivery, but the whole thing got broken when it turned out that the new TOML parser got generated with ANTLVv4 4.11.1.
   
   I'm still investigating the dependencies, but I would like some feedback on the way I handled the Json Parser upgrade.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #4845: Upgrade ANTLRv4 Runtime to 4.11.1

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4845:
URL: https://github.com/apache/netbeans/pull/4845#issuecomment-1364008202

   Rebased on master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #4845: Upgrade ANTLRv4 Runtime to 4.11.1

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4845:
URL: https://github.com/apache/netbeans/pull/4845#issuecomment-1364327039

   @matthiasblaesing I've updated the release version and the sig file in the last commit. It seems the tomlj API has changed a bit. Also removed `orj.tomlj.internal` from the sigtest. Could you pleas check if that commit makes sense to you! Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #4845: Upgrade ANTLRv4 Runtime to 4.11.1

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4845:
URL: https://github.com/apache/netbeans/pull/4845#issuecomment-1296272324

   This is major problem and this moves antlr for me into the corner of "you should not use it". This is not antlr 4.11, but 5.1 (4.10 broke compatibility). From my POV we have to treat it as such. At least we have to bump the release version, so the module would then be named `org.netbeans.libs.antlr4.runtime/2`. Or a new module is created, that holds versions 4.10+. I have seen antrl4 in the truffle area, so all depending modules need to be checked.
   
   The changes to the JSON parser look sane to me. These cause unittest errors in `javascript2.editor` module, but these look harmless (Patch: [javascript2.editor.zip](https://github.com/apache/netbeans/files/9896046/javascript2.editor.zip)).
   
   The transitive problems seem to be much harder.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #4845: Upgrade ANTLRv4 Runtime to 4.11.1

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4845:
URL: https://github.com/apache/netbeans/pull/4845#issuecomment-1298936788

   I think this is missing the update of the TOML parser (at least some of the test failures seem to indicate this). What is more, the licenses need to be fixed. This should make  `verify-libs-and-licenses`  happy:  [fix_verify_libs_and_licenses.patch.zip](https://github.com/apache/netbeans/files/9913019/fix_verify_libs_and_licenses.patch.zip). The patch can be applied with "git apply".
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #4845: Upgrade ANTLRv4 Runtime to 4.11.1

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4845:
URL: https://github.com/apache/netbeans/pull/4845#issuecomment-1298952499

   Yes, my TOML update is on a separate branch, I have to integrate that here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi merged pull request #4845: Upgrade ANTLRv4 Runtime to 4.11.1

Posted by GitBox <gi...@apache.org>.
lkishalmi merged PR #4845:
URL: https://github.com/apache/netbeans/pull/4845


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #4845: Upgrade ANTLRv4 Runtime to 4.11.1

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4845:
URL: https://github.com/apache/netbeans/pull/4845#issuecomment-1288019365

   I had to split the Json.g4 mixed parser into a lexer and a parser grammar, as lexer channels are no longer supported in mixed grammars. That resulted some glitch in the generated visitor and listener names.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] lkishalmi commented on pull request #4845: Upgrade ANTLRv4 Runtime to 4.11.1

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #4845:
URL: https://github.com/apache/netbeans/pull/4845#issuecomment-1296361755

   Checked the other dependencies. Surprisingly, it is just the JSON and its dependencties, TOML, and the ANTL support (those are leaf modules, so that'd be fine.) Groovy uses ANTLR, but it provides it's own runtime.
   We have the CSS and a JavaCommand line lexer/parser in ANTLRv3, and some reverences on external ANTLR v2 libs in eclipselink and struts. 
   I have not found ANTLR v4 references in Truffle.
   
   Agree on the release version `/2` and generally that this should be ANTLR 5.1. But that's what it is.
   
   Thanks for the patch! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #4845: Upgrade ANTLRv4 Runtime to 4.11.1

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4845:
URL: https://github.com/apache/netbeans/pull/4845#issuecomment-1364547813

   Looks sane to me. The test failure indicates, that the json parser module needs it sigfiles regenerated and most probably the major version bumped (uuncriticial as it is  a friend-only export and it is in-tree).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists