[jira] [Commented] (FINERACT-1643) Catch external_id duplicates for loan transactions

["John Woodlock (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556434#comment-17556434 ] 

John Woodlock commented on FINERACT-1643:
-----------------------------------------


The following loan transactions are catered for in this Pull Request (other loan transactions can be done in different Jira issues):

Credit Balance Refund (has existing duplicate externalId test)
Repayment
Goodwill Credit
Merchant Issued Refund
Payout Refund
Disbursement
Add Loan Charge (has existing duplicate externalId test)

> Catch external_id duplicates for loan transactions
> --------------------------------------------------
>
>                 Key: FINERACT-1643
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1643
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: Loan
>    Affects Versions: 1.7.0
>            Reporter: John Woodlock
>            Assignee: John Woodlock
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> Currently, most loan transactions that allow externalId as an API parameter result in 500 Internal Server Error if externalId is a duplicate.
> Credit Balance Refund & 'Adding Loan Charge' do pick-up and test for externalId duplicates but the code that picks these up is itself 'duplicated'.
> This improvement is to use a general DataIntegrityErrorHandler method for loan transactions that picks up on JpaSystemException and DataIntegrityViolationException exceptions highlighting duplicate externalIds in particular.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)