You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2017/11/10 23:28:00 UTC
[jira] [Commented] (OOZIE-2942) Fix Findbugs warnings in
oozie-examples
[ https://issues.apache.org/jira/browse/OOZIE-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248163#comment-16248163 ]
Hadoop QA commented on OOZIE-2942:
----------------------------------
Testing JIRA OOZIE-2942
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
. {color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 2054
. Tests rerun: 57
. Tests failed at first run: org.apache.oozie.command.coord.TestCoordActionsKillXCommand,org.apache.oozie.action.hadoop.TestJavaActionExecutor,
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/208/
> Fix Findbugs warnings in oozie-examples
> ---------------------------------------
>
> Key: OOZIE-2942
> URL: https://issues.apache.org/jira/browse/OOZIE-2942
> Project: Oozie
> Issue Type: Sub-task
> Components: build
> Reporter: Jan Hentschel
> Assignee: Jan Hentschel
> Fix For: 5.0.0b1
>
> Attachments: OOZIE-2942-1.patch, OOZIE-2942-2.patch
>
>
> Currently Findbugs complains about the following warnings in the *oozie-examples* module:
> {code}
> [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close stream on exception [org.apache.oozie.example.DateList] At DateList.java:[line 69]
> [INFO] Nullcheck of date at line 55 of value previously dereferenced in org.apache.oozie.example.DateList.main(String[]) [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
> [INFO] Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called [org.apache.oozie.example.DateList] At DateList.java:[line 97]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource created at LocalOozieExample.java:[line 72] is not dischargedPath continues at LocalOozieExample.java:[line 76]Path continues at LocalOozieExample.java:[line 77]Path continues at LocalOozieExample.java:[line 78]Path continues at LocalOozieExample.java:[line 81]Path continues at LocalOozieExample.java:[line 88]Path continues at LocalOozieExample.java:[line 89]Path continues at LocalOozieExample.java:[line 91]Path continues at LocalOozieExample.java:[line 100]
> [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to close stream [org.apache.oozie.example.LocalOozieExample] At LocalOozieExample.java:[line 72]
> [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal representation by returning Repeatable.baseline [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
> [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose internal representation by storing an externally mutable object into Repeatable.baseline [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 172]
> {code}
> They should be fixed to get the code more reliable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)