[GitHub] [incubator-mxnet] anirudh2290 commented on issue #14397: [WIP] Add exception handling support for waitall

[GitBox <gi...@apache.org>]

anirudh2290 commented on issue #14397: [WIP] Add exception handling support for waitall
URL: https://github.com/apache/incubator-mxnet/pull/14397#issuecomment-471870654
 
 
   We had earlier decided this based on complication associated with adding global exception_ptr and having to reset all the exception_ptrs corresponding to vars and ops.Another, reason was the performance impact. I think we overestimated the difficulty since the decision to used shared_ptr<exception_ptr> enables us to modify the exception_ptrs associated with vars and ops by just setting it  to nullptr. Also, there would be performance implication if there is an exception in the code and this can be more pronounced for a tool supposed to used only for benchmarking. But customers seems to be using it outside benchmarking and the performance impact will only happen when there is an exception thrown so it should be acceptable. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services