You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "SbloodyS (via GitHub)" <gi...@apache.org> on 2023/07/25 09:32:02 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #14634: [CI][E2E] Upgrade e2e dependency version

SbloodyS commented on code in PR #14634:
URL: https://github.com/apache/dolphinscheduler/pull/14634#discussion_r1273264862


##########
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/cases/ClickhouseDataSourceE2ETest.java:
##########
@@ -80,10 +82,10 @@ void testCreateClickhouseDataSource() {
 
         page.createDataSource(dataSourceType, dataSourceName, dataSourceDescription, ip, port, userName, pgPassword, database, jdbcParams);
 
-        new WebDriverWait(page.driver(), 10).until(ExpectedConditions.invisibilityOfElementLocated(
+        new WebDriverWait(page.driver(), Duration.ofSeconds(20)).until(ExpectedConditions.invisibilityOfElementLocated(

Review Comment:
   > we change value from 10 to 20 for longer timeout?
   
   Yes...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org