You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ksobrenat32 (via GitHub)" <gi...@apache.org> on 2025/07/10 03:16:30 UTC

[PR] Stale pubsub subscriptions cleaner [beam]

ksobrenat32 opened a new pull request, #35553:
URL: https://github.com/apache/beam/pull/35553

   This PRimproves the `stale_cleaner` tool by introducing functionality to clean up stale PubSub subscriptions, alongside existing support for PubSub topics. It also includes unit tests to validate the new functionality.
   
   ### Code added
   
   * Added a new `PubSubSubscriptionCleaner` class to handle stale PubSub subscriptions. This includes methods for listing active subscriptions, applying prefix filtering, checking if subscriptions are detached, and deleting stale subscriptions. 
   
   ### Updates to existing code
   
   * Created a function for calling each cleaner instance, this way we can just run certain cleaner without refreshing all.
   
   ### Minor fixes
   
   * Updated the `delete_topic` method call in the `PubSubTopicCleanerTest` class to align with the new request format from: #35513


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Stale pubsub subscriptions cleaner [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35553:
URL: https://github.com/apache/beam/pull/35553#issuecomment-3055328574

   Assigning reviewers:
   
   R: @kennknowles added as fallback since no labels match configuration
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Stale pubsub subscriptions cleaner [beam]

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem merged PR #35553:
URL: https://github.com/apache/beam/pull/35553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org