You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by akashrn5 <gi...@git.apache.org> on 2018/07/23 15:09:22 UTC

[GitHub] carbondata pull request #2541: [CARBONDATA-2771]block update and delete on t...

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2541

    [CARBONDATA-2771]block update and delete on table if the compaction is in progress

    ### Problem:
    if update is triggered when comapction is in progress, in some cases there will be data miss match and sometimes update fails as the segmentId mapping which is used in getPartitions may differ, during update operation.
    
    ### Solution
    Block update and delete if compaction is in progress for table
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [x] Any interfaces changed?
     NA
     - [x] Any backward compatibility impacted?
     NA
     - [x] Document update required?
    NA
     - [x] Testing done
    UTs are added
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata update_compact

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2541.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2541
    
----

----


---

[GitHub] carbondata pull request #2541: [CARBONDATA-2771]block update and delete on t...

Posted by kumarvishal09 <gi...@git.apache.org>.

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2541#discussion_r204656119
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java ---
    @@ -769,6 +769,26 @@ public static Boolean isLoadInProgressInTable(CarbonTable carbonTable) {
         return loadInProgress;
       }
     
    +  /**
    +   * Return true if the compaction is in progress for the table
    +   * @param carbonTable
    +   * @return
    +   */
    +  public static Boolean isCompactionInProgress(CarbonTable carbonTable) {
    +    if (carbonTable == null) {
    +      return false;
    +    }
    +    boolean compactionInProgress;
    +    ICarbonLock lock = CarbonLockFactory
    +        .getCarbonLockObj(carbonTable.getAbsoluteTableIdentifier(), LockUsage.COMPACTION_LOCK);
    +    try {
    +      compactionInProgress = !lock.lockWithRetries();
    --- End diff --
    
    call lockWithRetries(int retryCount, int retryInterval) with retrycount 1 


---

[GitHub] carbondata issue #2541: [CARBONDATA-2771]block update and delete on table if...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2541
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7410/



---

[GitHub] carbondata issue #2541: [CARBONDATA-2771]block update and delete on table if...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2541
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6174/



---

[GitHub] carbondata issue #2541: [CARBONDATA-2771]block update and delete on table if...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2541
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5992/



---

[GitHub] carbondata issue #2541: [CARBONDATA-2771]block update and delete on table if...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2541
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5980/



---

[GitHub] carbondata issue #2541: [CARBONDATA-2771]block update and delete on table if...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2541
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6212/



---

[GitHub] carbondata issue #2541: [CARBONDATA-2771]block update and delete on table if...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2541
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6221/



---

[GitHub] carbondata issue #2541: [CARBONDATA-2771]block update and delete on table if...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2541
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6202/



---

[GitHub] carbondata issue #2541: [CARBONDATA-2771]block update and delete on table if...

Posted by akashrn5 <gi...@git.apache.org>.

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2541
  
    retest this please 


---

[GitHub] carbondata issue #2541: [CARBONDATA-2771]block update and delete on table if...

Posted by kumarvishal09 <gi...@git.apache.org>.

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2541
  
    LGTM


---