You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by sy...@apache.org on 2005/06/10 18:31:28 UTC

svn commit: r189982 - /cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Field.java /cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Form.java /cocoon/branches/BRANCH_2_1_X/status.xml

Author: sylvain
Date: Fri Jun 10 09:31:26 2005
New Revision: 189982

URL: http://svn.apache.org/viewcvs?rev=189982&view=rev
Log:
Fix bug#35311 - ensure FormHandler is always called when a field's value changes. Thanks to Jeffrey Kirby

Modified:
    cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Field.java
    cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Form.java
    cocoon/branches/BRANCH_2_1_X/status.xml

Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Field.java
URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Field.java?rev=189982&r1=189981&r2=189982&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Field.java (original)
+++ cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Field.java Fri Jun 10 09:31:26 2005
@@ -507,7 +507,9 @@
     }
 
     private boolean hasValueChangedListeners() {
-        return this.listener != null || this.fieldDefinition.hasValueChangedListeners();
+        return this.listener != null ||
+               this.fieldDefinition.hasValueChangedListeners() ||
+               this.getForm().hasFormHandler();
     }
 
     private void fireValueChangedEvent(ValueChangedEvent event) {

Modified: cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Form.java
URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Form.java?rev=189982&r1=189981&r2=189982&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Form.java (original)
+++ cocoon/branches/BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/formmodel/Form.java Fri Jun 10 09:31:26 2005
@@ -174,6 +174,10 @@
         this.submitWidget = widget;
     }
 
+    public boolean hasFormHandler() {
+       return (this.formHandler != null);
+    }
+
     public void setFormHandler(FormHandler formHandler) {
         this.formHandler = formHandler;
     }

Modified: cocoon/branches/BRANCH_2_1_X/status.xml
URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/status.xml?rev=189982&r1=189981&r2=189982&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/status.xml (original)
+++ cocoon/branches/BRANCH_2_1_X/status.xml Fri Jun 10 09:31:26 2005
@@ -196,6 +196,9 @@
 
   <changes>
   <release version="@version@" date="@date@">
+    <action dev="SW" type="fix" fixes-bug="35311" due-to="Jeffrey Kirby" due-to-email="jeff.kirby@wicourts.gov">
+      CForms block: Ensure FormHandler is always called when a field's value change.
+    </action>
     <action dev="RP" type="update">
       CForms block: The default HTML stylesheets have been moved into the jar packages. If they should
       be extended in custom stylesheets, import or include them using the resource protocol: