You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ma...@hyperreal.org on 1999/10/07 23:58:31 UTC
cvs commit: apache-2.0/src/lib/apr/misc/unix start.c
martin 99/10/07 14:58:31
Modified: src/lib/apr/misc/unix start.c
Log:
Warning: even with HAVE_PTHREAD_SIGMASK defined,
no pthread function should be called for the prefork mpm
Revision Changes Path
1.9 +3 -0 apache-2.0/src/lib/apr/misc/unix/start.c
Index: start.c
===================================================================
RCS file: /export/home/cvs/apache-2.0/src/lib/apr/misc/unix/start.c,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- start.c 1999/10/04 16:37:01 1.8
+++ start.c 1999/10/07 21:58:29 1.9
@@ -203,6 +203,9 @@
sigset_t sigset;
sigfillset(&sigset);
+ /*@@@ FIXME: This should *NOT* be called for the prefork MPM,
+ * even if HAVE_PTHREAD_SIGMASK is defined!!!! MnKr
+ */
pthread_sigmask(SIG_BLOCK, &sigset, NULL);
#endif
return APR_SUCCESS;
Re: cvs commit: apache-2.0/src/lib/apr/misc/unix start.c
Posted by Manoj Kasichainula <ma...@raleigh.ibm.com>.
On Thu, Oct 07, 1999 at 09:58:31PM -0000, martin@hyperreal.org wrote:
> Warning: even with HAVE_PTHREAD_SIGMASK defined,
> no pthread function should be called for the prefork mpm
Why not?
My reading of the definition of pthread_sigmask() is that it is only a
generalization of sigprocmask(), so that it actually works when
multithreaded.
http://www.opengroup.org/onlinepubs/007908799/xsh/sigprocmask.html
--
Manoj Kasichainula - manojk@raleigh.ibm.com
IBM, Apache Development
Re: cvs commit: apache-2.0/src/lib/apr/misc/unix start.c
Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
That's going to be difficult to accomplish, because officially, APR
doesn't have any idea what is being done in Apache. At least, that's my
understanding. I have tried really hard to avoid putting Apache specific
code into APR.
Ryan
On 7 Oct 1999 martin@hyperreal.org wrote:
> martin 99/10/07 14:58:31
>
> Modified: src/lib/apr/misc/unix start.c
> Log:
> Warning: even with HAVE_PTHREAD_SIGMASK defined,
> no pthread function should be called for the prefork mpm
_______________________________________________________________________
Ryan Bloom rbb@raleigh.ibm.com
4205 S Miami Blvd
RTP, NC 27709 It's a beautiful sight to see good dancers
doing simple steps. It's a painful sight to
see beginners doing complicated patterns.
Re: cvs commit: apache-2.0/src/lib/apr/misc/unix start.c
Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
That's going to be difficult to accomplish, because officially, APR
doesn't have any idea what is being done in Apache. At least, that's my
understanding. I have tried really hard to avoid putting Apache specific
code into APR.
Ryan
On 7 Oct 1999 martin@hyperreal.org wrote:
> martin 99/10/07 14:58:31
>
> Modified: src/lib/apr/misc/unix start.c
> Log:
> Warning: even with HAVE_PTHREAD_SIGMASK defined,
> no pthread function should be called for the prefork mpm
_______________________________________________________________________
Ryan Bloom rbb@raleigh.ibm.com
4205 S Miami Blvd
RTP, NC 27709 It's a beautiful sight to see good dancers
doing simple steps. It's a painful sight to
see beginners doing complicated patterns.