You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/25 16:22:13 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1123: SOLR-16491: Create v2 equivalent for /admin/info/key
gerlowskija opened a new pull request, #1123:
URL: https://github.com/apache/solr/pull/1123
https://issues.apache.org/jira/browse/SOLR-16491
# Description
The /admin/info/key API used to retrieve a node's public key has no v2 equivalent.
# Solution
This PR adds a v2 equivalent using the JAX-RS framework, the new endpoint is `GET /api/node/key`. In implementing this, some shared logic around key-creation was refactored into a separate class, `SolrNodeKeyPair`, which is created by CoreContainer and made injectable to the JAX-RS framework to that a single instance (i.e. same key) can be used by both the existing v1 RH, and the new v2 binding.
# Tests
A new simple unit test in `PublicKeyAPITest`; existing tests for pki-auth and the PublicKeyHandler continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1123: SOLR-16491: Create v2 equivalent for /admin/info/key
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on PR #1123:
URL: https://github.com/apache/solr/pull/1123#issuecomment-1290827670
Still needs ref-guide coverage and a full test-run, but should be ready for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1123: SOLR-16491: Create v2 equivalent for /admin/info/key
Posted by GitBox <gi...@apache.org>.
gerlowskija merged PR #1123:
URL: https://github.com/apache/solr/pull/1123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org