You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anurag Singh <an...@gmail.com> on 2016/04/04 18:12:25 UTC
Re: Review Request 44670: Added master_detector and master_contender
flags.
> On March 31, 2016, 5:26 p.m., Kapil Arya wrote:
> > src/master/main.cpp, lines 247-248
> > <https://reviews.apache.org/r/44670/diff/7/?file=1308601#file1308601line247>
> >
> > These two should fit on one line :-).
putting them on the same line is causing the line lenght to increase to 89.
- Anurag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44670/#review126356
-----------------------------------------------------------
On March 23, 2016, 11:06 p.m., Anurag Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44670/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 11:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Kapil Arya.
>
>
> Bugs: MESOS-4610
> https://issues.apache.org/jira/browse/MESOS-4610
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The master_detector and master_contender flags allow modules to be
> used for specifying the MasterContender and MasterDetector
> implementations to use.
>
>
> Diffs
> -----
>
> src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d
> src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61
> src/master/main.cpp 61210d9f275d4073967c3468179307cf09e88551
> src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388
> src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3
> src/slave/main.cpp 33a1af84aeb079224b15e92caf97bcf081ea4646
>
> Diff: https://reviews.apache.org/r/44670/diff/
>
>
> Testing
> -------
>
> In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters).
>
>
> Thanks,
>
> Anurag Singh
>
>