You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Vladimir Steshin <vl...@gmail.com> on 2020/01/26 16:21:03 UTC
Task to implement: IGNITE-12581
Hi everyone.
How do you think, can I start this task:
https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-12581 ?
It looks useful and seems good for a newbie to begin researching the
code and test techniques.
Re: Task to implement: IGNITE-12581
Posted by Vladimir Steshin <vl...@gmail.com>.
Ivan, thanks. It's ok. I'm waiting for the test results, researching the
code, doing next simple ticket.
ср, 29 янв. 2020 г., 10:38 Ivan Pavlukhin <vo...@gmail.com>:
> Vladimir,
>
> Do no hesitate to write back if you need any assistance, e.g. troubles
> with code or a code review.
>
> пн, 27 янв. 2020 г. в 13:28, Vladimir Steshin <vl...@gmail.com>:
> >
> > Ok. Forgot to explain the ticket. I'm going to bring some refactoring to
> > the test, replace inheritance with parametrization. Many tests use
> > extending to handle params like
> >
> > public class JdbcThinBulkLoadAtomicReplicatedSelfTest extends
> > JdbcThinBulkLoadAbstractSelfTest {
> > /** {@inheritDoc} */
> > @Override protected CacheMode cacheMode() {
> > return CacheMode.REPLICATED;
> > }
> >
> > /** {@inheritDoc} */
> > @Override protected CacheAtomicityMode atomicityMode() {
> > return CacheAtomicityMode.ATOMIC;
> > }
> >
> > /** {@inheritDoc} */
> > @Override protected boolean nearCache() {
> > return false;
> > }
> > }
> >
> >
> > We might involve JUnit's params reducing code amount.
> >
> >
> >
> >
> > We might involve
> >
> >
> > пн, 27 янв. 2020 г. в 11:38, Maksim Stepachev <
> maksim.stepachev@gmail.com>:
> >
> > > Hi,
> > >
> > > I suppose you can.
> > > Nikolay possibly may help with it.
> > > If you have the telegram, join to Russian channel:
> https://t.me/RU_Ignite
> > >
> > > вс, 26 янв. 2020 г. в 19:21, Vladimir Steshin <vl...@gmail.com>:
> > >
> > > > Hi everyone.
> > > >
> > > > How do you think, can I start this task:
> > > > https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-12581 ?
> > > >
> > > > It looks useful and seems good for a newbie to begin researching the
> > > > code and test techniques.
> > > >
> > > >
> > >
>
>
>
> --
> Best regards,
> Ivan Pavlukhin
>
Re: Task to implement: IGNITE-12581
Posted by Ivan Pavlukhin <vo...@gmail.com>.
Vladimir,
Do no hesitate to write back if you need any assistance, e.g. troubles
with code or a code review.
пн, 27 янв. 2020 г. в 13:28, Vladimir Steshin <vl...@gmail.com>:
>
> Ok. Forgot to explain the ticket. I'm going to bring some refactoring to
> the test, replace inheritance with parametrization. Many tests use
> extending to handle params like
>
> public class JdbcThinBulkLoadAtomicReplicatedSelfTest extends
> JdbcThinBulkLoadAbstractSelfTest {
> /** {@inheritDoc} */
> @Override protected CacheMode cacheMode() {
> return CacheMode.REPLICATED;
> }
>
> /** {@inheritDoc} */
> @Override protected CacheAtomicityMode atomicityMode() {
> return CacheAtomicityMode.ATOMIC;
> }
>
> /** {@inheritDoc} */
> @Override protected boolean nearCache() {
> return false;
> }
> }
>
>
> We might involve JUnit's params reducing code amount.
>
>
>
>
> We might involve
>
>
> пн, 27 янв. 2020 г. в 11:38, Maksim Stepachev <ma...@gmail.com>:
>
> > Hi,
> >
> > I suppose you can.
> > Nikolay possibly may help with it.
> > If you have the telegram, join to Russian channel: https://t.me/RU_Ignite
> >
> > вс, 26 янв. 2020 г. в 19:21, Vladimir Steshin <vl...@gmail.com>:
> >
> > > Hi everyone.
> > >
> > > How do you think, can I start this task:
> > > https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-12581 ?
> > >
> > > It looks useful and seems good for a newbie to begin researching the
> > > code and test techniques.
> > >
> > >
> >
--
Best regards,
Ivan Pavlukhin
Re: Task to implement: IGNITE-12581
Posted by Vladimir Steshin <vl...@gmail.com>.
Ok. Forgot to explain the ticket. I'm going to bring some refactoring to
the test, replace inheritance with parametrization. Many tests use
extending to handle params like
public class JdbcThinBulkLoadAtomicReplicatedSelfTest extends
JdbcThinBulkLoadAbstractSelfTest {
/** {@inheritDoc} */
@Override protected CacheMode cacheMode() {
return CacheMode.REPLICATED;
}
/** {@inheritDoc} */
@Override protected CacheAtomicityMode atomicityMode() {
return CacheAtomicityMode.ATOMIC;
}
/** {@inheritDoc} */
@Override protected boolean nearCache() {
return false;
}
}
We might involve JUnit's params reducing code amount.
We might involve
пн, 27 янв. 2020 г. в 11:38, Maksim Stepachev <ma...@gmail.com>:
> Hi,
>
> I suppose you can.
> Nikolay possibly may help with it.
> If you have the telegram, join to Russian channel: https://t.me/RU_Ignite
>
> вс, 26 янв. 2020 г. в 19:21, Vladimir Steshin <vl...@gmail.com>:
>
> > Hi everyone.
> >
> > How do you think, can I start this task:
> > https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-12581 ?
> >
> > It looks useful and seems good for a newbie to begin researching the
> > code and test techniques.
> >
> >
>
Re: Task to implement: IGNITE-12581
Posted by Maksim Stepachev <ma...@gmail.com>.
Hi,
I suppose you can.
Nikolay possibly may help with it.
If you have the telegram, join to Russian channel: https://t.me/RU_Ignite
вс, 26 янв. 2020 г. в 19:21, Vladimir Steshin <vl...@gmail.com>:
> Hi everyone.
>
> How do you think, can I start this task:
> https://issues.apache.org/jira/projects/IGNITE/issues/IGNITE-12581 ?
>
> It looks useful and seems good for a newbie to begin researching the
> code and test techniques.
>
>