You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2016/01/30 00:55:24 UTC
Re: Review Request 42990: Suppressed AngularJS "Interpolation Error"
in browser console.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42990/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 6:55 p.m.)
Review request for mesos.
Summary (updated)
-----------------
Suppressed AngularJS "Interpolation Error" in browser console.
Repository: mesos
Description
-------
Suppressed Interpolation Error in browser console.
Diffs
-----
src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
Diff: https://reviews.apache.org/r/42990/diff/
Testing
-------
Verified that no errors are generated in the browser console.
Thanks,
Kapil Arya
Re: Review Request 42990: Suppressed AngularJS "Interpolation Error"
in browser console.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 30, 2016, 2:19 a.m., Mesos ReviewBot wrote:
> > Bad review!
> >
> > Reviews applied: []
> >
> > Error:
> > No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
I have a patch a bit related to this. https://reviews.apache.org/r/41864/diff/2#index_header
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42990/#review117081
-----------------------------------------------------------
On Jan. 30, 2016, 12:05 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42990/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2016, 12:05 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The "decimalFloat" filter was being applied to undefined variables causing an "Interpolation Error". We now check for 'undefined' and return 0 instead of applying the filter.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
>
> Diff: https://reviews.apache.org/r/42990/diff/
>
>
> Testing
> -------
>
> Verified that no errors are generated in the browser console.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 42990: Suppressed AngularJS "Interpolation Error"
in browser console.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42990/#review117081
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos ReviewBot
On Jan. 30, 2016, 12:05 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42990/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2016, 12:05 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The "decimalFloat" filter was being applied to undefined variables causing an "Interpolation Error". We now check for 'undefined' and return 0 instead of applying the filter.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
>
> Diff: https://reviews.apache.org/r/42990/diff/
>
>
> Testing
> -------
>
> Verified that no errors are generated in the browser console.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 42990: Suppressed AngularJS "Interpolation Error"
in browser console.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42990/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 7:05 p.m.)
Review request for mesos.
Repository: mesos
Description (updated)
-------
The "decimalFloat" filter was being applied to undefined variables causing an "Interpolation Error". We now check for 'undefined' and return 0 instead of applying the filter.
Diffs
-----
src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
Diff: https://reviews.apache.org/r/42990/diff/
Testing
-------
Verified that no errors are generated in the browser console.
Thanks,
Kapil Arya
Re: Review Request 42990: Suppressed AngularJS "Interpolation Error"
in browser console.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42990/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 7 p.m.)
Review request for mesos.
Repository: mesos
Description (updated)
-------
Suppressed Interpolation Error in browser console. Here is an example:
https://docs.angularjs.org/error/$interpolate/interr?p0=%7B%7Btotal_cpus%20%7C%20decimalFloat%7D%7D&p1=TypeError:%20Cannot%20read%20property%20%27toFixed%27%20of%20undefined
Diffs
-----
src/webui/master/static/js/controllers.js 36865f1cd6a4518ba30cd6e64d4d7347762066ec
Diff: https://reviews.apache.org/r/42990/diff/
Testing
-------
Verified that no errors are generated in the browser console.
Thanks,
Kapil Arya