You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/24 04:07:14 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4216: PQL
-> SQL enhancement - phase 1 - new Pinot Query Struct
codecov-io edited a comment on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#issuecomment-493376612
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=h1) Report
> Merging [#4216](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/7bb797d1ba1a8e2c1f1df33fb6b847e154df6423?src=pr&el=desc) will **decrease** coverage by `1.93%`.
> The diff coverage is `30.5%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4216 +/- ##
============================================
- Coverage 67.39% 65.46% -1.94%
Complexity 20 20
============================================
Files 1041 1051 +10
Lines 51505 54768 +3263
Branches 7216 7805 +589
============================================
+ Hits 34712 35853 +1141
- Misses 14428 16313 +1885
- Partials 2365 2602 +237
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/pinot/pql/parsers/pql2/ast/PredicateAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9QcmVkaWNhdGVBc3ROb2RlLmphdmE=) | `50% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...t/pql/parsers/pql2/ast/BooleanOperatorAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9Cb29sZWFuT3BlcmF0b3JBc3ROb2RlLmphdmE=) | `27.77% <0%> (-3.48%)` | `0 <0> (ø)` | |
| [...inot/pql/parsers/pql2/ast/FunctionCallAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9GdW5jdGlvbkNhbGxBc3ROb2RlLmphdmE=) | `51.61% <0%> (+3.12%)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/pinot/common/request/InstanceRequestV2.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9JbnN0YW5jZVJlcXVlc3RWMi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...not/pql/parsers/pql2/ast/PredicateListAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9QcmVkaWNhdGVMaXN0QXN0Tm9kZS5qYXZh) | `93.02% <100%> (+3.93%)` | `0 <0> (ø)` | :arrow_down: |
| [...che/pinot/pql/parsers/pql2/ast/OptionsAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9PcHRpb25zQXN0Tm9kZS5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/pql/parsers/pql2/ast/SelectAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9TZWxlY3RBc3ROb2RlLmphdmE=) | `96.34% <100%> (+0.68%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/pql/parsers/pql2/ast/HavingAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9IYXZpbmdBc3ROb2RlLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../pql/parsers/pql2/ast/OutputColumnListAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9PdXRwdXRDb2x1bW5MaXN0QXN0Tm9kZS5qYXZh) | `70% <100%> (+7.5%)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/pinot/common/utils/request/RequestUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9SZXF1ZXN0VXRpbHMuamF2YQ==) | `96.58% <100%> (+0.58%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [83 more](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=footer). Last update [7bb797d...09ae2e5](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org