You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Adrian Cole <no...@github.com> on 2013/09/30 00:48:51 UTC
[jclouds-labs-openstack] JCLOUDS-308. Add Temporary Url Support to
openstack-swift (#32)
This adds the ability to sign temporary urls.
Note that this passes in rackspace, but not in HPCS. HPCS uses a non-standard signature process.
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs-openstack openstack-swift-temporary-url
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/32
-- Commit Summary --
* JCLOUDS-308. Add Temporary Url Support to openstack-swift
-- File Changes --
A openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/TemporaryUrlSigner.java (92)
M openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/domain/Account.java (5)
M openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/features/AccountApi.java (20)
A openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/TemporaryUrlSignerLiveTest.java (91)
A openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/TemporaryUrlSignerMockTest.java (75)
M openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/AccountApiMockTest.java (20)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/32.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/32.diff
Re: [jclouds-labs-openstack] JCLOUDS-308. Add Temporary Url Support
to openstack-swift (#32)
Posted by Andrew Phillips <no...@github.com>.
@adriancole There's a "(c) Netflix" header in one of the files...is that intentional?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/32#issuecomment-27156576
Re: [jclouds-labs-openstack] JCLOUDS-308. Add Temporary Url Support
to openstack-swift (#32)
Posted by Andrew Phillips <no...@github.com>.
> +
> + public static TemporaryUrlSigner checkApiEvery(final AccountApi api, long seconds) {
> + Supplier<String> keySupplier = memoizeWithExpiration(new TemporaryUrlKeyFromAccount(api), seconds, SECONDS);
> + return new TemporaryUrlSigner(keySupplier);
> + }
> +
> + private final Supplier<String> keySupplier;
> +
> + TemporaryUrlSigner(Supplier<String> keySupplier) {
> + this.keySupplier = keySupplier;
> + }
> +
> + public String sign(String method, String path, long expirationTimestampSeconds) {
> + checkNotNull(method, "method");
> + checkNotNull(path, "path");
> + checkArgument(expirationTimestampSeconds > 0, "expirationTimestamp must be a unix epoch timestamp");
"...but was: %d"?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/32/files#r7235165
Re: [jclouds-labs-openstack] JCLOUDS-308. Add Temporary Url Support
to openstack-swift (#32)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #61](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/61/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/32#issuecomment-25331056
Re: [jclouds-labs-openstack] JCLOUDS-308. Add Temporary Url Support
to openstack-swift (#32)
Posted by Adrian Cole <no...@github.com>.
commit fd3f8cd01991363db91f90bb7f22133af1988061
Author: Adrian Cole <ad...@gmail.com>
Date: Sun Sep 29 15:42:46 2013 -0700
JCLOUDS-308. Add Temporary Url Support to openstack-swift
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/32#issuecomment-25331631
Re: [jclouds-labs-openstack] JCLOUDS-308. Add Temporary Url Support
to openstack-swift (#32)
Posted by Andrew Phillips <no...@github.com>.
> @@ -0,0 +1,92 @@
> +/*
> + * Copyright 2013 Netflix, Inc.
Header??
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/32/files#r7235164