You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Robert Spier <rs...@pobox.com> on 2006/02/24 07:02:35 UTC

[PATCH] for_repos in default section for mailer.py

Apparently [defaults].for_repos hasn't worked in a while, at least not
for me.  I traced this through a few months ago and the matches were
being thrown away.  Now, as I go through the upgrade cycle, I'm
finally submitting the patch.


 * tools/hook-scripts/mailer/mailer.py
   (Config._prep_groups): Update the global parameter structure with
   params extracted from [defaults].for_repos so they can be used later. 

--- tools/hook-scripts/mailer/mailer.py~  2006-02-23 21:45:42.000000000 -0800
+++ tools/hook-scripts/mailer/mailer.py   2006-02-23 22:14:08.000000000 -0800
@@ -1140,6 +1140,7 @@
       match = re.match(self.defaults.for_repos, repos_dir)
       if match:
         default_params.update(match.groupdict())
+        self._global_params.update(match.groupdict())
     except AttributeError:
       # there is no self.defaults.for_repos
       pass

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] for_repos in default section for mailer.py

Posted by Robert Spier <rs...@pobox.com>.
> Robert Spier wrote:
> > Apparently [defaults].for_repos hasn't worked in a while, at least not
> > for me.  I traced this through a few months ago and the matches were
> > being thrown away.  Now, as I go through the upgrade cycle, I'm
> > finally submitting the patch.
> 
> Too late :-)
> Already fixed in r18114.

Doh, thanks!

-R

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] for_repos in default section for mailer.py

Posted by Max Bowsher <ma...@ukf.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Spier wrote:
> Apparently [defaults].for_repos hasn't worked in a while, at least not
> for me.  I traced this through a few months ago and the matches were
> being thrown away.  Now, as I go through the upgrade cycle, I'm
> finally submitting the patch.

Too late :-)
Already fixed in r18114.

Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFD/u2tfFNSmcDyxYARAqM9AKDP80RL9o7DszD+0ESmGylCHO/DYACfQ+bV
OXWGBzl0d3ztqU0+DL/zYRs=
=ZBfl
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org