[jira] [Updated] (KARAF-4288) karaf-maven-plugin doesn't pass custom settings.xml option onto pax-url-aether

["Stuart McCulloch (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KARAF-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stuart McCulloch updated KARAF-4288:
------------------------------------
    Attachment: KARAF-4288.patch

Suggested patch which passes custom settings.xml onto pax-url-aether

Note if the user settings.xml file doesn't exist pax-url-aether already has logic to discover the global settings.xml file, so we don't need to explicitly pass that on.

> karaf-maven-plugin doesn't pass custom settings.xml option onto pax-url-aether
> ------------------------------------------------------------------------------
>
>                 Key: KARAF-4288
>                 URL: https://issues.apache.org/jira/browse/KARAF-4288
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-tooling
>    Affects Versions: 4.0.4
>            Reporter: Stuart McCulloch
>         Attachments: KARAF-4288.patch
>
>
> When adding features to a custom distribution karaf-maven-plugin uses pax-url-aether to fetch artifacts which don't yet exist in the local maven repository.
> pax-url-aether has logic to discover the local repository and settings.xml file, but this relies on defaults plus a few heuristics. If a Maven build uses a custom settings.xml file which contains auth details, ie. when running on CI, then this is not picked up by pax-url-aether and it cannot fetch down additional content.
> The current user settings file is accessible from the MavenSession:
>    MavenSession->getRequest->getUserSettingsFile
> and the session is available from the mojo. All that needs to be done is pass on this path to pax-url-aether by setting the "org.ops4j.pax.url.mvn.settings" system property. (Note the user settings file may be null or may not exist, in which case the global settings path should be passed to pax-url-aether)
> (I'll attach a patch that implements this suggested solution)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)