[jira] [Commented] (KAFKA-5446) Annoying braces showed on log.error using streams

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049191#comment-16049191 ] 

ASF GitHub Bot commented on KAFKA-5446:
---------------------------------------

GitHub user ppatierno opened a pull request:

    https://github.com/apache/kafka/pull/3338

    KAFKA-5446: Annoying braces showed on log.error using streams

    Fixed log.error usage with annoying braces

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ppatierno/kafka log-error

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3338
    
----
commit dcf8308e04663295f9310632dcfc226ea58cd947
Author: ppatierno <pp...@live.com>
Date:   2017-06-14T13:35:11Z

    Fixed LOG.error usage with annoying braces

----


> Annoying braces showed on log.error using streams 
> --------------------------------------------------
>
>                 Key: KAFKA-5446
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5446
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Paolo Patierno
>            Priority: Trivial
>
> Hi,
> in the stream library seems to be a wrong usage of the log.error method when we want to show an exception. There are useless braces at the end of the line before showing exception information like the following example :
> ERROR task [0_0] Could not close task due to {} (org.apache.kafka.streams.processor.internals.StreamTask:414)
> org.apache.kafka.clients.consumer.CommitFailedException: Commit cannot be completed since the group has already rebalanced and assigned the partitions to another member. This means that the time between subsequent calls to poll() was longer than the configured max.poll.interval.ms, which typically implies that the poll loop is spending too much time message processing. You can address this either by increasing the session timeout or by reducing the maximum size of batches returned in poll() with max.poll.records.
> 	at org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.sendOffsetCommitRequest(ConsumerCoordinator.java:725)
> 	at org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.commitOffsetsSync(ConsumerCoordinator.java:604)
> 	at org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1146)
> as you can see in ".... due to {}", the braces aren't needed for showing exception info so they are printed.
> Thanks,
> Paolo.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)