You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/05/07 03:39:46 UTC

Review Request 21144: Always show resource consumption table on Job page.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21144/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: AURORA-386
    https://issues.apache.org/jira/browse/AURORA-386


Repository: aurora


Description
-------

Always show resource consumption table on job page.


Diffs
-----

  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7c80bd769b7e80bef0822846166959925b1bf7f8 
  src/main/resources/org/apache/aurora/scheduler/http/ui/role.html ff631c8d2befa03920e3a0c7ca7c52812063cf0a 

Diff: https://reviews.apache.org/r/21144/diff/


Testing
-------

Tested on local laptop. Screenshots attached.


File Attachments
----------------

Screen Shot 2014-05-06 at 6.38.46 PM.png
  https://reviews.apache.org/media/uploaded/files/2014/05/07/bc2d25f8-79ef-4f3e-b44f-81e668bd32b8__Screen_Shot_2014-05-06_at_6.38.46_PM.png


Thanks,

Suman Karumuri


Re: Review Request 21144: Always show resource consumption table on Job page.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21144/#review42594
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On May 7, 2014, 1:39 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21144/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 1:39 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-386
>     https://issues.apache.org/jira/browse/AURORA-386
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Always show resource consumption table on job page.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7c80bd769b7e80bef0822846166959925b1bf7f8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html ff631c8d2befa03920e3a0c7ca7c52812063cf0a 
> 
> Diff: https://reviews.apache.org/r/21144/diff/
> 
> 
> Testing
> -------
> 
> Tested on local laptop. Screenshots attached.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2014-05-06 at 6.38.46 PM.png
>   https://reviews.apache.org/media/uploaded/files/2014/05/07/bc2d25f8-79ef-4f3e-b44f-81e668bd32b8__Screen_Shot_2014-05-06_at_6.38.46_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>


Re: Review Request 21144: Always show resource consumption table on Job page.

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21144/#review42583
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On May 7, 2014, 1:39 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21144/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 1:39 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-386
>     https://issues.apache.org/jira/browse/AURORA-386
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Always show resource consumption table on job page.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7c80bd769b7e80bef0822846166959925b1bf7f8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html ff631c8d2befa03920e3a0c7ca7c52812063cf0a 
> 
> Diff: https://reviews.apache.org/r/21144/diff/
> 
> 
> Testing
> -------
> 
> Tested on local laptop. Screenshots attached.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2014-05-06 at 6.38.46 PM.png
>   https://reviews.apache.org/media/uploaded/files/2014/05/07/bc2d25f8-79ef-4f3e-b44f-81e668bd32b8__Screen_Shot_2014-05-06_at_6.38.46_PM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>