You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/07 07:14:12 UTC

[GitHub] [shardingsphere] tristaZero opened a new issue #10696: Create `AlterTableStatementFederateRefresher`

tristaZero opened a new issue #10696:
URL: https://github.com/apache/shardingsphere/issues/10696


   Hi community,
   
   This issue needs more effort than good-first-issue. Hope you can enjoy it. :)
   
   ### Target 
   - Create a class named `AlterTableStatementFederateRefresher` which is to renew `FederateSchemaMetadata` when users execute `alter table xxx` SQL. (It is simple to figure out that once the table structure changes, the metadata needs to be refreshed accordingly)
   - Add a unit test for your change
   
   ### How
   - Create a class named `AlterTableStatementFederateRefresher` implementing `FederateRefresher<AlterTableStatement>`
   Here are some tips,
   1. Please refer to `CreateTableStatementFederateRefresher` and `AlterTableStatementSchemaRefresher`
   2. The keypoint is to get the latest `TableMetaData` and call `FederateSchemaMetadata`.`renew()`. That way, `AlterTableStatementSchemaRefresher` will help you know how to create a `TableMetaData` 
   - Add a unit test similar to `AlterTableStatementSchemaRefresherTest` and #10695
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] MingxingLAI commented on issue #10696: Create `AlterTableStatementFederateRefresher`

Posted by GitBox <gi...@apache.org>.
MingxingLAI commented on issue #10696:
URL: https://github.com/apache/shardingsphere/issues/10696#issuecomment-855673410


   Can I take this issue and #10697 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yinyichao commented on issue #10696: Create `AlterTableStatementFederateRefresher`

Posted by GitBox <gi...@apache.org>.
yinyichao commented on issue #10696:
URL: https://github.com/apache/shardingsphere/issues/10696#issuecomment-855770569


   Please assign to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on issue #10696: Create `AlterTableStatementFederateRefresher`

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #10696:
URL: https://github.com/apache/shardingsphere/issues/10696#issuecomment-855708674


   > Can I take this issue and #10697 ?
   
   @MingxingLAI Assigned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero closed issue #10696: Create `AlterTableStatementFederateRefresher`

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #10696:
URL: https://github.com/apache/shardingsphere/issues/10696


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org