You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2015/09/08 02:41:20 UTC

[37/50] logging-log4j2 git commit: Use final.

Use final.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/49fa817c
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/49fa817c
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/49fa817c

Branch: refs/heads/master
Commit: 49fa817c35aa5b915f424335c6bde8a657b6ccb0
Parents: dbe1157
Author: ggregory <gg...@apache.org>
Authored: Tue Sep 1 14:57:40 2015 -0700
Committer: ggregory <gg...@apache.org>
Committed: Tue Sep 1 14:57:40 2015 -0700

----------------------------------------------------------------------
 .../core/config/builder/api/Component.java      | 10 +--
 .../api/ConfigurationBuilderFactory.java        |  2 +-
 .../config/builder/impl/BuiltConfiguration.java | 26 ++++----
 .../impl/DefaultAppenderComponentBuilder.java   |  8 +--
 .../DefaultAppenderRefComponentBuilder.java     |  6 +-
 ...DefaultComponentAndConfigurationBuilder.java | 12 ++--
 .../builder/impl/DefaultComponentBuilder.java   | 26 ++++----
 .../DefaultCompositeFilterComponentBuilder.java |  6 +-
 .../impl/DefaultConfigurationBuilder.java       | 70 ++++++++++----------
 .../DefaultCustomLevelComponentBuilder.java     |  4 +-
 .../impl/DefaultFilterComponentBuilder.java     |  4 +-
 .../impl/DefaultLayoutComponentBuilder.java     |  2 +-
 .../impl/DefaultLoggerComponentBuilder.java     | 12 ++--
 .../impl/DefaultRootLoggerComponentBuilder.java | 12 ++--
 14 files changed, 100 insertions(+), 100 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/Component.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/Component.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/Component.java
index 6d5556a..55d29b5 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/Component.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/Component.java
@@ -32,15 +32,15 @@ public class Component {
     private final String pluginType;
     private final String value;
 
-    public Component(String pluginType) {
+    public Component(final String pluginType) {
         this(pluginType, null, null);
     }
 
-    public Component(String pluginType, String name) {
+    public Component(final String pluginType, final String name) {
         this(pluginType, name, null);
     }
 
-    public Component(String pluginType, String name, String value) {
+    public Component(final String pluginType, final String name, final String value) {
         this.pluginType = pluginType;
         this.value = value;
         if (name != null && name.length() > 0) {
@@ -54,11 +54,11 @@ public class Component {
     }
 
 
-    public String addAttribute(String key, String value) {
+    public String addAttribute(final String key, final String value) {
         return attributes.put(key, value);
     }
 
-    public void addComponent(Component component) {
+    public void addComponent(final Component component) {
         components.add(component);
     }
 

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/ConfigurationBuilderFactory.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/ConfigurationBuilderFactory.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/ConfigurationBuilderFactory.java
index da1b81c..4418d38 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/ConfigurationBuilderFactory.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/ConfigurationBuilderFactory.java
@@ -33,7 +33,7 @@ public class ConfigurationBuilderFactory {
         return new DefaultConfigurationBuilder<>();
     }
 
-    public static <T extends BuiltConfiguration> ConfigurationBuilder<T> newConfigurationBuilder(Class<T> clazz) {
+    public static <T extends BuiltConfiguration> ConfigurationBuilder<T> newConfigurationBuilder(final Class<T> clazz) {
         return new DefaultConfigurationBuilder<>(clazz);
     }
 }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/BuiltConfiguration.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/BuiltConfiguration.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/BuiltConfiguration.java
index fd4ddf0..0b838d2 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/BuiltConfiguration.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/BuiltConfiguration.java
@@ -47,10 +47,10 @@ public class BuiltConfiguration extends AbstractConfiguration {
     private Component propertiesComponent;
     private Component customLevelsComponent;
 
-    public BuiltConfiguration(ConfigurationSource source, Component rootComponent) {
+    public BuiltConfiguration(final ConfigurationSource source, final Component rootComponent) {
         super(source);
         statusConfig = new StatusConfiguration().withVerboseClasses(VERBOSE_CLASSES).withStatus(getDefaultStatus());
-        for (Component component : rootComponent.getComponents()) {
+        for (final Component component : rootComponent.getComponents()) {
             switch (component.getPluginType()) {
                 case "Loggers": {
                     loggersComponent = component;
@@ -79,7 +79,7 @@ public class BuiltConfiguration extends AbstractConfiguration {
 
     @Override
     public void setup() {
-        List<Node> children = rootNode.getChildren();
+        final List<Node> children = rootNode.getChildren();
         if (propertiesComponent.getComponents().size() > 0) {
             children.add(convertToNode(rootNode, propertiesComponent));
         }
@@ -102,17 +102,17 @@ public class BuiltConfiguration extends AbstractConfiguration {
         return statusConfig;
     }
 
-    public void setPluginPackages(String packages) {
+    public void setPluginPackages(final String packages) {
         pluginPackages.addAll(Arrays.asList(packages.split(Patterns.COMMA_SEPARATOR)));
     }
 
-    public void setShutdownHook(String flag) {
+    public void setShutdownHook(final String flag) {
         isShutdownHookEnabled = !"disable".equalsIgnoreCase(flag);
     }
 
-    public void setMonitorInterval(int intervalSeconds) {
+    public void setMonitorInterval(final int intervalSeconds) {
         if (this instanceof Reconfigurable && intervalSeconds > 0) {
-            ConfigurationSource configSource = getConfigurationSource();
+            final ConfigurationSource configSource = getConfigurationSource();
             if (configSource != null) {
                 final File configFile = configSource.getFile();
                 if (intervalSeconds > 0 && configFile != null) {
@@ -126,14 +126,14 @@ public class BuiltConfiguration extends AbstractConfiguration {
         return pluginManager;
     }
 
-    protected Node convertToNode(Node parent, Component component) {
-        String name = component.getPluginType();
-        PluginType<?> pluginType = pluginManager.getPluginType(name);
-        Node node = new Node(parent, name, pluginType);
+    protected Node convertToNode(final Node parent, final Component component) {
+        final String name = component.getPluginType();
+        final PluginType<?> pluginType = pluginManager.getPluginType(name);
+        final Node node = new Node(parent, name, pluginType);
         node.getAttributes().putAll(component.getAttributes());
         node.setValue(component.getValue());
-        List<Node> children = node.getChildren();
-        for (Component child : component.getComponents()) {
+        final List<Node> children = node.getChildren();
+        for (final Component child : component.getComponents()) {
             children.add(convertToNode(node, child));
         }
         return node;

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java
index cdaeb96..e66e835 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderComponentBuilder.java
@@ -27,18 +27,18 @@ import org.apache.logging.log4j.core.config.builder.api.LayoutComponentBuilder;
 class DefaultAppenderComponentBuilder extends DefaultComponentAndConfigurationBuilder<AppenderComponentBuilder>
         implements AppenderComponentBuilder {
 
-    public DefaultAppenderComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder, String name,
-            String type) {
+    public DefaultAppenderComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder, final String name,
+            final String type) {
         super(builder, name, type);
     }
 
     @Override
-    public AppenderComponentBuilder add(LayoutComponentBuilder builder) {
+    public AppenderComponentBuilder add(final LayoutComponentBuilder builder) {
         return addComponent(builder);
     }
 
     @Override
-    public AppenderComponentBuilder add(FilterComponentBuilder builder) {
+    public AppenderComponentBuilder add(final FilterComponentBuilder builder) {
         return addComponent(builder);
     }
 }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java
index 7ee5f0f..1016624 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultAppenderRefComponentBuilder.java
@@ -26,15 +26,15 @@ import org.apache.logging.log4j.core.config.builder.api.FilterComponentBuilder;
 class DefaultAppenderRefComponentBuilder extends DefaultComponentAndConfigurationBuilder<AppenderRefComponentBuilder>
         implements AppenderRefComponentBuilder {
 
-    public DefaultAppenderRefComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder,
-            String ref) {
+    public DefaultAppenderRefComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder,
+            final String ref) {
         super(builder, "AppenderRef");
         addAttribute("ref", ref);
     }
 
 
     @Override
-    public AppenderRefComponentBuilder add(FilterComponentBuilder builder) {
+    public AppenderRefComponentBuilder add(final FilterComponentBuilder builder) {
         return addComponent(builder);
     }
 }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentAndConfigurationBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentAndConfigurationBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentAndConfigurationBuilder.java
index d4c2b36..44e71b5 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentAndConfigurationBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentAndConfigurationBuilder.java
@@ -27,18 +27,18 @@ import org.apache.logging.log4j.core.config.builder.api.ComponentBuilder;
 class DefaultComponentAndConfigurationBuilder<T extends ComponentBuilder<T>>
         extends DefaultComponentBuilder<T, DefaultConfigurationBuilder<? extends Configuration>> {
 
-    DefaultComponentAndConfigurationBuilder(DefaultConfigurationBuilder<? extends Configuration> builder, String name,
-            String type, String value) {
+    DefaultComponentAndConfigurationBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder, final String name,
+            final String type, final String value) {
         super(builder, name, type, value);
     }
 
-    DefaultComponentAndConfigurationBuilder(DefaultConfigurationBuilder<? extends Configuration> builder, String name,
-            String type) {
+    DefaultComponentAndConfigurationBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder, final String name,
+            final String type) {
         super(builder, name, type);
     }
 
-    public DefaultComponentAndConfigurationBuilder(DefaultConfigurationBuilder<? extends Configuration> builder,
-            String type) {
+    public DefaultComponentAndConfigurationBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder,
+            final String type) {
         super(builder, type);
     }
 

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentBuilder.java
index 9c7ed59..af313fb 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultComponentBuilder.java
@@ -41,16 +41,16 @@ class DefaultComponentBuilder<T extends ComponentBuilder<T>, CB extends Configur
     private String name;
     private String value;
 
-    public DefaultComponentBuilder(CB builder, String type) {
+    public DefaultComponentBuilder(final CB builder, final String type) {
         this(builder, null, type, null);
     }
 
-    public DefaultComponentBuilder(CB builder, String name, String type) {
+    public DefaultComponentBuilder(final CB builder, final String name, final String type) {
         this(builder, name, type, null);
     }
 
-    public DefaultComponentBuilder(CB builder, String name, String type,
-            String value) {
+    public DefaultComponentBuilder(final CB builder, final String name, final String type,
+            final String value) {
         this.type = type;
         this.builder = builder;
         this.name = name;
@@ -58,47 +58,47 @@ class DefaultComponentBuilder<T extends ComponentBuilder<T>, CB extends Configur
     }
 
     @Override
-    public T addAttribute(String key, boolean value) {
+    public T addAttribute(final String key, final boolean value) {
         return put(key, Boolean.toString(value));
     }
     
     @Override
-    public T addAttribute(String key, Enum<?> value) {
+    public T addAttribute(final String key, final Enum<?> value) {
         return put(key, value.name());
     }
 
     @Override
-    public T addAttribute(String key, int value) {
+    public T addAttribute(final String key, final int value) {
         return put(key, Integer.toString(value));
     }
 
 
     @Override
-    public T addAttribute(String key, Level level) {
+    public T addAttribute(final String key, final Level level) {
         return put(key, level.toString());
     }
 
     @Override
-    public T addAttribute(String key, Object value) {
+    public T addAttribute(final String key, final Object value) {
         return put(key, value.toString());
     }
 
 
     @Override
-    public T addAttribute(String key, String value) {
+    public T addAttribute(final String key, final String value) {
         return put(key, value);
     }
 
     @Override
     @SuppressWarnings("unchecked")
-    public T addComponent(ComponentBuilder<?> builder) {
+    public T addComponent(final ComponentBuilder<?> builder) {
         components.add(builder.build());
         return (T) this;
     }
 
     @Override
     public Component build() {
-        Component component = new Component(type, name, value);
+        final Component component = new Component(type, name, value);
         component.getAttributes().putAll(attributes);
         component.getComponents().addAll(components);
         return component;
@@ -114,7 +114,7 @@ class DefaultComponentBuilder<T extends ComponentBuilder<T>, CB extends Configur
         return name;
     }
 
-    protected T put(String key, String value) {
+    protected T put(final String key, final String value) {
         attributes.put(key, value);
         return (T) this;
     }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java
index b9bb80d..f1d50e9 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCompositeFilterComponentBuilder.java
@@ -27,15 +27,15 @@ class DefaultCompositeFilterComponentBuilder
         extends DefaultComponentAndConfigurationBuilder<CompositeFilterComponentBuilder>
         implements CompositeFilterComponentBuilder {
 
-    public DefaultCompositeFilterComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder,
-            String onMatch, String onMisMatch) {
+    public DefaultCompositeFilterComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder,
+            final String onMatch, final String onMisMatch) {
         super(builder, "Filters");
         addAttribute("onMatch", onMatch);
         addAttribute("onMisMatch", onMisMatch);
     }
 
     @Override
-    public CompositeFilterComponentBuilder add(FilterComponentBuilder builder) {
+    public CompositeFilterComponentBuilder add(final FilterComponentBuilder builder) {
         return addComponent(builder);
     }
 

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java
index fb76f8a..96890ee 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultConfigurationBuilder.java
@@ -70,12 +70,12 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement
         root.addAttribute("name", "Assembled");
     }
 
-    public DefaultConfigurationBuilder(Class<T> clazz) {
+    public DefaultConfigurationBuilder(final Class<T> clazz) {
         if (clazz == null) {
             throw new IllegalArgumentException("A Configuration class must be provided");
         }
         this.clazz = clazz;
-        List<Component> components = root.getComponents();
+        final List<Component> components = root.getComponents();
         properties = new Component("Properties");
         components.add(properties);
         customLevels = new Component("CustomLevels");
@@ -88,34 +88,34 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement
         components.add(loggers);
     }
     
-    protected ConfigurationBuilder<T> add(Component parent, ComponentBuilder<?> builder) {
+    protected ConfigurationBuilder<T> add(final Component parent, final ComponentBuilder<?> builder) {
         parent.getComponents().add(builder.build());
         return this;
     }
 
     @Override
-    public ConfigurationBuilder<T> add(AppenderComponentBuilder builder) {
+    public ConfigurationBuilder<T> add(final AppenderComponentBuilder builder) {
         return add(appenders, builder);
     }
 
     @Override
-    public ConfigurationBuilder<T> add(CustomLevelComponentBuilder builder) {
+    public ConfigurationBuilder<T> add(final CustomLevelComponentBuilder builder) {
         return add(customLevels, builder);
     }
 
     @Override
-    public ConfigurationBuilder<T> add(FilterComponentBuilder builder) {
+    public ConfigurationBuilder<T> add(final FilterComponentBuilder builder) {
         return add(filters, builder);
     }
 
     @Override
-    public ConfigurationBuilder<T> add(LoggerComponentBuilder builder) {
+    public ConfigurationBuilder<T> add(final LoggerComponentBuilder builder) {
         return add(loggers, builder);
     }
 
     @Override
-    public ConfigurationBuilder<T> add(RootLoggerComponentBuilder builder) {
-        for (Component c : loggers.getComponents()) {
+    public ConfigurationBuilder<T> add(final RootLoggerComponentBuilder builder) {
+        for (final Component c : loggers.getComponents()) {
             if (c.getPluginType().equals("root")) {
                 throw new ConfigurationException("Root Logger was previously defined");
             }
@@ -124,7 +124,7 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement
     }
 
     @Override
-    public ConfigurationBuilder<T> addProperty(String key, String value) {
+    public ConfigurationBuilder<T> addProperty(final String key, final String value) {
         properties.addComponent(newComponent(key, "Property", value).build());
         return this;
     }
@@ -136,7 +136,7 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement
             if (source == null) {
                 source = ConfigurationSource.NULL_SOURCE;
             }
-            Constructor<T> constructor = clazz.getConstructor(ConfigurationSource.class, Component.class);
+            final Constructor<T> constructor = clazz.getConstructor(ConfigurationSource.class, Component.class);
             configuration = constructor.newInstance(source, root);
             configuration.setMonitorInterval(monitorInterval);
             if (name != null) {
@@ -154,7 +154,7 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement
             if (shutdownFlag != null) {
                 configuration.setShutdownHook(shutdownFlag);
             }
-        } catch (Exception ex) {
+        } catch (final Exception ex) {
             throw new IllegalArgumentException("Invalid Configuration class specified", ex);
         }
         configuration.getStatusConfiguration().initialize();
@@ -163,84 +163,84 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement
     }
 
     @Override
-    public AppenderComponentBuilder newAppender(String name, String type) {
+    public AppenderComponentBuilder newAppender(final String name, final String type) {
         return new DefaultAppenderComponentBuilder(this, name, type);
     }
 
     @Override
-    public AppenderRefComponentBuilder newAppenderRef(String ref) {
+    public AppenderRefComponentBuilder newAppenderRef(final String ref) {
         return new DefaultAppenderRefComponentBuilder(this, ref);
     }
 
     @Override
-    public LoggerComponentBuilder newAsyncLogger(String name, Level level) {
+    public LoggerComponentBuilder newAsyncLogger(final String name, final Level level) {
         return new DefaultLoggerComponentBuilder(this, name, level.toString(), "AsyncLogger");
     }
 
     @Override
-    public LoggerComponentBuilder newAsyncLogger(String name, String level) {
+    public LoggerComponentBuilder newAsyncLogger(final String name, final String level) {
         return new DefaultLoggerComponentBuilder(this, name, level, "AsyncLogger");
     }
 
     @Override
-    public RootLoggerComponentBuilder newAsyncRootLogger(Level level) {
+    public RootLoggerComponentBuilder newAsyncRootLogger(final Level level) {
         return new DefaultRootLoggerComponentBuilder(this, level.toString(), "AsyncRoot");
     }
 
     @Override
-    public RootLoggerComponentBuilder newAsyncRootLogger(String level) {
+    public RootLoggerComponentBuilder newAsyncRootLogger(final String level) {
         return new DefaultRootLoggerComponentBuilder(this, level, "AsyncRoot");
     }
 
     @Override
-    public <B extends ComponentBuilder<B>> ComponentBuilder<B> newComponent(String name, String type) {
+    public <B extends ComponentBuilder<B>> ComponentBuilder<B> newComponent(final String name, final String type) {
         return new DefaultComponentBuilder<>(this, name, type);
     }
 
     @Override
-    public <B extends ComponentBuilder<B>> ComponentBuilder<B> newComponent(String name, String type, String value) {
+    public <B extends ComponentBuilder<B>> ComponentBuilder<B> newComponent(final String name, final String type, final String value) {
         return new DefaultComponentBuilder<>(this, name, type, value);
     }
 
 
     @Override
-    public CustomLevelComponentBuilder newCustomLevel(String name, int level) {
+    public CustomLevelComponentBuilder newCustomLevel(final String name, final int level) {
         return new DefaultCustomLevelComponentBuilder(this, name, level);
     }
 
     @Override
-    public FilterComponentBuilder newFilter(String type, Filter.Result onMatch, Filter.Result onMisMatch) {
+    public FilterComponentBuilder newFilter(final String type, final Filter.Result onMatch, final Filter.Result onMisMatch) {
         return new DefaultFilterComponentBuilder(this, type, onMatch.name(), onMisMatch.name());
     }
 
     @Override
-    public FilterComponentBuilder newFilter(String type, String onMatch, String onMisMatch) {
+    public FilterComponentBuilder newFilter(final String type, final String onMatch, final String onMisMatch) {
         return new DefaultFilterComponentBuilder(this, type, onMatch, onMisMatch);
     }
 
     @Override
-    public LayoutComponentBuilder newLayout(String type) {
+    public LayoutComponentBuilder newLayout(final String type) {
         return new DefaultLayoutComponentBuilder(this, type);
     }
 
 
     @Override
-    public LoggerComponentBuilder newLogger(String name, Level level) {
+    public LoggerComponentBuilder newLogger(final String name, final Level level) {
         return new DefaultLoggerComponentBuilder(this, name, level.toString());
     }
 
     @Override
-    public LoggerComponentBuilder newLogger(String name, String level) {
+    public LoggerComponentBuilder newLogger(final String name, final String level) {
         return new DefaultLoggerComponentBuilder(this, name, level);
     }
 
     @Override
-    public RootLoggerComponentBuilder newRootLogger(Level level) {
+    public RootLoggerComponentBuilder newRootLogger(final Level level) {
         return new DefaultRootLoggerComponentBuilder(this, level.toString());
     }
 
     @Override
-    public RootLoggerComponentBuilder newRootLogger(String level) {
+    public RootLoggerComponentBuilder newRootLogger(final String level) {
         return new DefaultRootLoggerComponentBuilder(this, level);
     }
 
@@ -251,7 +251,7 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement
      * @return this builder instance
      */
     @Override
-    public ConfigurationBuilder<T> setConfigurationName(String name) {
+    public ConfigurationBuilder<T> setConfigurationName(final String name) {
         this.name = name;
         return this;
     }
@@ -263,37 +263,37 @@ public class DefaultConfigurationBuilder<T extends BuiltConfiguration> implement
      * @return this builder instance
      */
     @Override
-    public ConfigurationBuilder<T> setConfigurationSource(ConfigurationSource configurationSource) {
+    public ConfigurationBuilder<T> setConfigurationSource(final ConfigurationSource configurationSource) {
         source = configurationSource;
         return this;
     }
 
     @Override
-    public ConfigurationBuilder<T> setMonitorInterval(String intervalSeconds) {
+    public ConfigurationBuilder<T> setMonitorInterval(final String intervalSeconds) {
         monitorInterval = Integer.parseInt(intervalSeconds);
         return this;
     }
 
     @Override
-    public ConfigurationBuilder<T> setPackages(String packages) {
+    public ConfigurationBuilder<T> setPackages(final String packages) {
         this.packages = packages;
         return this;
     }
 
     @Override
-    public ConfigurationBuilder<T> setShutdownHook(String flag) {
+    public ConfigurationBuilder<T> setShutdownHook(final String flag) {
         this.shutdownFlag = flag;
         return this;
     }
 
     @Override
-    public ConfigurationBuilder<T> setStatusLevel(Level level) {
+    public ConfigurationBuilder<T> setStatusLevel(final Level level) {
         this.level = level;
         return this;
     }
 
     @Override
-    public ConfigurationBuilder<T> setVerbosity(String verbosity) {
+    public ConfigurationBuilder<T> setVerbosity(final String verbosity) {
         this.verbosity = verbosity;
         return this;
     }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCustomLevelComponentBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCustomLevelComponentBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCustomLevelComponentBuilder.java
index 378582b..94f2637 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCustomLevelComponentBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultCustomLevelComponentBuilder.java
@@ -25,8 +25,8 @@ import org.apache.logging.log4j.core.config.builder.api.CustomLevelComponentBuil
 class DefaultCustomLevelComponentBuilder extends DefaultComponentAndConfigurationBuilder<CustomLevelComponentBuilder>
         implements CustomLevelComponentBuilder {
 
-    public DefaultCustomLevelComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder,
-            String name, int level) {
+    public DefaultCustomLevelComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder,
+            final String name, final int level) {
         super(builder, name, "CustomLevel");
         addAttribute("level", Integer.toString(level));
     }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultFilterComponentBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultFilterComponentBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultFilterComponentBuilder.java
index 362b3ec..437dcc4 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultFilterComponentBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultFilterComponentBuilder.java
@@ -25,8 +25,8 @@ import org.apache.logging.log4j.core.config.builder.api.FilterComponentBuilder;
 class DefaultFilterComponentBuilder extends DefaultComponentAndConfigurationBuilder<FilterComponentBuilder>
         implements FilterComponentBuilder {
 
-    public DefaultFilterComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder, String type,
-            String onMatch, String onMisMatch) {
+    public DefaultFilterComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder, final String type,
+            final String onMatch, final String onMisMatch) {
         super(builder, type);
         addAttribute("onMatch", onMatch);
         addAttribute("onMisMatch", onMisMatch);

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLayoutComponentBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLayoutComponentBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLayoutComponentBuilder.java
index 275f7db..a1c9794 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLayoutComponentBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLayoutComponentBuilder.java
@@ -25,7 +25,7 @@ import org.apache.logging.log4j.core.config.builder.api.LayoutComponentBuilder;
 class DefaultLayoutComponentBuilder extends DefaultComponentAndConfigurationBuilder<LayoutComponentBuilder>
         implements LayoutComponentBuilder {
 
-    public DefaultLayoutComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder, String type) {
+    public DefaultLayoutComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder, final String type) {
         super(builder, type);
     }
 }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java
index f72c76a..047b51d 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultLoggerComponentBuilder.java
@@ -33,8 +33,8 @@ class DefaultLoggerComponentBuilder extends DefaultComponentAndConfigurationBuil
      * @param name
      * @param level
      */
-    public DefaultLoggerComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder, String name,
-            String level) {
+    public DefaultLoggerComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder, final String name,
+            final String level) {
         super(builder, name, "Logger");
         addAttribute("level", level);
     }
@@ -46,19 +46,19 @@ class DefaultLoggerComponentBuilder extends DefaultComponentAndConfigurationBuil
      * @param level
      * @param type
      */
-    public DefaultLoggerComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder, String name,
-            String level, String type) {
+    public DefaultLoggerComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder, final String name,
+            final String level, final String type) {
         super(builder, name, type);
         addAttribute("level", level);
     }
 
     @Override
-    public LoggerComponentBuilder add(AppenderRefComponentBuilder builder) {
+    public LoggerComponentBuilder add(final AppenderRefComponentBuilder builder) {
         return addComponent(builder);
     }
 
     @Override
-    public LoggerComponentBuilder add(FilterComponentBuilder builder) {
+    public LoggerComponentBuilder add(final FilterComponentBuilder builder) {
         return addComponent(builder);
     }
 }
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/49fa817c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java
index be266df..e3e39e6 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/impl/DefaultRootLoggerComponentBuilder.java
@@ -32,8 +32,8 @@ class DefaultRootLoggerComponentBuilder extends DefaultComponentAndConfiguration
      * @param builder
      * @param level
      */
-    public DefaultRootLoggerComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder,
-            String level) {
+    public DefaultRootLoggerComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder,
+            final String level) {
         super(builder, "", "Root");
         addAttribute("level", level);
     }
@@ -44,20 +44,20 @@ class DefaultRootLoggerComponentBuilder extends DefaultComponentAndConfiguration
      * @param level
      * @param type
      */
-    public DefaultRootLoggerComponentBuilder(DefaultConfigurationBuilder<? extends Configuration> builder,
-            String level, String type) {
+    public DefaultRootLoggerComponentBuilder(final DefaultConfigurationBuilder<? extends Configuration> builder,
+            final String level, final String type) {
         super(builder, "", type);
         addAttribute("level", level);
     }
 
     @Override
-    public RootLoggerComponentBuilder add(AppenderRefComponentBuilder builder) {
+    public RootLoggerComponentBuilder add(final AppenderRefComponentBuilder builder) {
         return addComponent(builder);
     }
 
 
     @Override
-    public RootLoggerComponentBuilder add(FilterComponentBuilder builder) {
+    public RootLoggerComponentBuilder add(final FilterComponentBuilder builder) {
         return addComponent(builder);
     }
 }
\ No newline at end of file