AccessLogValve Patch

[Jason Brittain <ja...@olliance.com>]

Hi guys.

Here's another patch to the AccessLogValve.  I noticed that since I
changed it to perform better, it was creating log files named
"localhost_access_log..txt".  It was a simple bug that I have found and
fixed (sorry about that).  Plus, I made a few other very minor modifications
that may in some cases make the AccessLogValve run slightly faster.

I also investigated (and tested) buffering the output to the access log,
and for some reason it's actually slower than when it's not buffered.
I have tried several different buffer sizes, and it doesn't seem to change
the performance any.  But, I've only tried this on Linux, and not on
other OSs.  I may be able to try it also on windows, but I wanted to see
first if anyone had ideas about this first..


Cheers.

-- 
Jason Brittain
Software Engineer, Olliance Inc.        http://www.Olliance.com
Current Maintainer, Locomotive Project  http://www.Locomotive.org

Re: AccessLogValve Patch

[Jason Brittain <ja...@olliance.com>]

In the message I just wrote:

> 
> --- AccessLogValve.java Wed Jan 10 15:16:10 2001
> +++ AccessLogValve.java-new     Wed Jan 10 15:15:50 2001
> @@ -61,6 +61,7 @@
>  package org.apache.catalina.valves;
>  
>  
> +import java.io.BufferedWriter;
>  import java.io.File;
>  import java.io.FileWriter;
>  import java.io.IOException;


Oops!  I forgot to remove the BufferedWriter import before I made
the patch..  Please remove that line.  Thanks!

-- 
Jason Brittain
Software Engineer, Olliance Inc.        http://www.Olliance.com
Current Maintainer, Locomotive Project  http://www.Locomotive.org