You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2018/06/26 00:31:24 UTC
zeppelin git commit: ZEPPELIN-3560. DisplayName in dynamic forms doesn't work

Repository: zeppelin
Updated Branches:
  refs/heads/master 31696b788 -> 53cbb10f7


ZEPPELIN-3560. DisplayName in dynamic forms doesn't work

### What is this PR for?

Use the displayName as the label instead of name.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3560

### Screenshots (if appropriate)
Before
![screen shot 2018-06-25 at 2 03 29 pm](https://user-images.githubusercontent.com/164491/41832928-d47c7f88-7880-11e8-920e-844828e9b1ef.png)

After
![screen shot 2018-06-25 at 2 02 55 pm](https://user-images.githubusercontent.com/164491/41832931-d8079c6e-7880-11e8-9f7b-558a93accd4d.png)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: Jeff Zhang <zj...@apache.org>

Closes #3042 from zjffdu/ZEPPELIN-3560 and squashes the following commits:

297d70320 [Jeff Zhang] ZEPPELIN-3560. DisplayName in dynamic forms doesn't work


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/53cbb10f
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/53cbb10f
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/53cbb10f

Branch: refs/heads/master
Commit: 53cbb10f70fd41f01cfa904133b2eb419ad5484f
Parents: 31696b7
Author: Jeff Zhang <zj...@apache.org>
Authored: Mon Jun 25 14:04:26 2018 +0800
Committer: Jeff Zhang <zj...@apache.org>
Committed: Tue Jun 26 08:31:08 2018 +0800

----------------------------------------------------------------------
 .../src/app/notebook/dynamic-forms/dynamic-forms.directive.html    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/53cbb10f/zeppelin-web/src/app/notebook/dynamic-forms/dynamic-forms.directive.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/dynamic-forms/dynamic-forms.directive.html b/zeppelin-web/src/app/notebook/dynamic-forms/dynamic-forms.directive.html
index 4f3e715..f9f6028 100644
--- a/zeppelin-web/src/app/notebook/dynamic-forms/dynamic-forms.directive.html
+++ b/zeppelin-web/src/app/notebook/dynamic-forms/dynamic-forms.directive.html
@@ -17,7 +17,7 @@ limitations under the License.
   <div class="form-group col-sm-6 col-md-6 col-lg-4"
        ng-repeat="formulaire in forms | toArray"
        ng-init="loadForm(formulaire, params)">
-    <label class="control-label input-sm" ng-class="{'disable': disable}">{{formulaire.name}}</label>
+    <label class="control-label input-sm" ng-class="{'disable': disable}">{{formulaire.displayName}}</label>
     <a ng-if="removeaction">
       <i class="fa fa-times"
          ng-click="removeaction(formulaire.name)"