You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:14:23 UTC
[GitHub] [incubator-hop] hansva commented on a change in pull request #350: Implementing audit as plugin
hansva commented on a change in pull request #350:
URL: https://github.com/apache/incubator-hop/pull/350#discussion_r516619770
##########
File path: assemblies/plugins/misc/audit/src/assembly/assembly.xml
##########
@@ -0,0 +1,33 @@
+<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3 http://maven.apache.org/xsd/assembly-1.1.3.xsd">
+
+ <id>hop-assemblies-plugins-misc-audit</id>
+ <formats>
+ <format>zip</format>
+ </formats>
+ <baseDirectory>misc/audit</baseDirectory>
+ <files>
+ <file>
+ <source>${project.basedir}/src/main/resources/version.xml</source>
+ <outputDirectory>.</outputDirectory>
+ <filtered>true</filtered>
+ </file>
+ </files>
+ <fileSets>
+ <fileSet>
+ <outputDirectory>lib</outputDirectory>
+ <excludes>
+ <exclude>**/*</exclude>
+ </excludes>
+ </fileSet>
+ </fileSets>
+ <dependencySets>
+ <dependencySet>
+ <useProjectArtifact>false</useProjectArtifact>
+ <includes>
+ <include>org.hop:hop-plugins-misc-audit:jar</include>
Review comment:
org.apache.hop:....
##########
File path: plugins/misc/audit/pom.xml
##########
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>hop-plugins-misc-audit</artifactId>
+ <packaging>jar</packaging>
+
+ <name>Hop Plugins Miscellaneous Audit</name>
+
+ <parent>
+ <groupId>org.hop</groupId>
Review comment:
same
##########
File path: plugins/misc/audit/pom.xml
##########
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>hop-plugins-misc-audit</artifactId>
+ <packaging>jar</packaging>
+
+ <name>Hop Plugins Miscellaneous Audit</name>
+
+ <parent>
+ <groupId>org.hop</groupId>
+ <artifactId>hop-plugins-misc</artifactId>
+ <version>0.40-SNAPSHOT</version>
Review comment:
0.50-SNAPSHOT
##########
File path: assemblies/plugins/misc/audit/pom.xml
##########
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.hop</groupId>
Review comment:
org.apache.hop
##########
File path: assemblies/plugins/misc/audit/pom.xml
##########
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.hop</groupId>
+ <artifactId>hop-assemblies-plugins-misc</artifactId>
+ <version>0.40-SNAPSHOT</version>
Review comment:
0.50-SNAPSHOT
##########
File path: assemblies/plugins/dist/pom.xml
##########
@@ -2842,6 +2842,19 @@
</exclusion>
</exclusions>
</dependency>
+
+ <dependency>
+ <groupId>org.hop</groupId>
Review comment:
Group Id has changed to org.apache.hop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org