You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/25 19:08:24 UTC
[GitHub] [incubator-superset] rusackas commented on issue #8648: Prettify
the frontend code
rusackas commented on issue #8648: Prettify the frontend code
URL: https://github.com/apache/incubator-superset/pull/8648#issuecomment-558297078
I'm happy to see the scattered `.prettierrc` files disappear... I almost did that, but wasn't sure the history/emotions attached to those.
In the remaining `.prettierrc` I see the rules are to go with single quotes, and trailing commas. I like the trailing commas for commit/blame history. For quotes, I'd be inclined to go with Prettier's defaults, unless people feel passionate about those single quotes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org