You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/05/12 13:00:21 UTC

Review Request 21318: Space Error in container-executor.cfg

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21318/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5730
    https://issues.apache.org/jira/browse/AMBARI-5730


Repository: ambari


Description
-------

There is a space between "banned.user" and "=" which make configuration here is ignored by container-executor, so some default banned users works to include hdfs. Space should be deleted between "banned.user" and "="

{noformat}
yarn.nodemanager.local-dirs=/grid/0/hadoop/yarn/local,/grid/1/hadoop/yarn/local
yarn.nodemanager.log-dirs=/grid/0/hadoop/yarn/log,/grid/1/hadoop/yarn/log
yarn.nodemanager.linux-container-executor.group=hadoop
banned.users = hdfs,yarn,mapred,bin
min.user.id=1000
{noformat}

It should be 
{noformat}
banned.users=hdfs,yarn,mapred,bin
{noformat}


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/templates/container-executor.cfg.j2 06143fa 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/templates/container-executor.cfg.j2 29ad949 

Diff: https://reviews.apache.org/r/21318/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi


Re: Review Request 21318: Space Error in container-executor.cfg

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21318/
-----------------------------------------------------------

(Updated May 12, 2014, 11:11 a.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5730
    https://issues.apache.org/jira/browse/AMBARI-5730


Repository: ambari


Description
-------

There is a space between "banned.user" and "=" which make configuration here is ignored by container-executor, so some default banned users works to include hdfs. Space should be deleted between "banned.user" and "="

{noformat}
yarn.nodemanager.local-dirs=/grid/0/hadoop/yarn/local,/grid/1/hadoop/yarn/local
yarn.nodemanager.log-dirs=/grid/0/hadoop/yarn/log,/grid/1/hadoop/yarn/log
yarn.nodemanager.linux-container-executor.group=hadoop
banned.users = hdfs,yarn,mapred,bin
min.user.id=1000
{noformat}

It should be 
{noformat}
banned.users=hdfs,yarn,mapred,bin
{noformat}


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/templates/container-executor.cfg.j2 06143fa 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/templates/container-executor.cfg.j2 29ad949 

Diff: https://reviews.apache.org/r/21318/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi


Re: Review Request 21318: Space Error in container-executor.cfg

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21318/#review42679
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On May 12, 2014, 11 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21318/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 11 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5730
>     https://issues.apache.org/jira/browse/AMBARI-5730
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is a space between "banned.user" and "=" which make configuration here is ignored by container-executor, so some default banned users works to include hdfs. Space should be deleted between "banned.user" and "="
> 
> {noformat}
> yarn.nodemanager.local-dirs=/grid/0/hadoop/yarn/local,/grid/1/hadoop/yarn/local
> yarn.nodemanager.log-dirs=/grid/0/hadoop/yarn/log,/grid/1/hadoop/yarn/log
> yarn.nodemanager.linux-container-executor.group=hadoop
> banned.users = hdfs,yarn,mapred,bin
> min.user.id=1000
> {noformat}
> 
> It should be 
> {noformat}
> banned.users=hdfs,yarn,mapred,bin
> {noformat}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/templates/container-executor.cfg.j2 06143fa 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/package/templates/container-executor.cfg.j2 29ad949 
> 
> Diff: https://reviews.apache.org/r/21318/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>