[GitHub] cnsgithub edited a comment on issue #27: MYFACES-4266: Ajax update fails due to invalid characters in response XML (DoS)

[GitBox <gi...@apache.org>]

cnsgithub edited a comment on issue #27: MYFACES-4266: Ajax update fails due to invalid characters in response XML (DoS)
URL: https://github.com/apache/myfaces/pull/27#issuecomment-441158458
 
 
   > Of course - but this methods uses char and char[]:
   > 
   > ```
   > public void write(int c) throws IOException 
   > public void write(char[] cbuf, int off, int len) throws IOException 
   > ```
   > There is no need to wrap it by a string
   
   Sorry, I don't see any problem here since `xmlEncode` has been overloaded three times to fit all `write` variations, i.e. `write(char[],int,in) `is using `xmlEncode(char[])`, `write(int) `is using `xmlEncode(char)` and just `write(String,off,len) `is using `xmlEncode(String)`.
   
   Edit: @tandraschko Okay, now I see, just added another commit. :wink: 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services