You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by mhfrantz <gi...@git.apache.org> on 2015/04/23 01:28:49 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-639 selectList (v4)

GitHub user mhfrantz opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/56

    TINKERPOP3-639 selectList (v4)

    Replaces PR #55.  Since that PR, integration tests now pass.  One bug (in computing the traverser requirements) was fixed, and some tests were disabled for `COMPUTER` mode.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RedSeal-co/incubator-tinkerpop TINKERPOP3-639-selectList.v4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
    
----
commit 2c8042d3a2ebbb9e208731d678d8bfe1d74bb3f4
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-15T00:39:18Z

    TINKERPOP3-549 Add Path getLast and getList

commit 5ffc95b0b8d97b443fa6f4cf397e167d6e11ca5e
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-15T01:04:50Z

    TINKERPOP3-549 Add unit test for SparsePath

commit 679388f111bf60f1d1b651da1dd3e6a1b056a771
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-17T00:22:38Z

    TINKERPOP3-549 Provide SparsePath implementations of getLast and getList
    
    - getLast == get
    - getList is disallowed

commit 8b4073347d7b78870798912a0df895884847de65
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-17T19:14:47Z

    TINKERPOP3-639 Add TraversalUtil.applyEach in support of selectList

commit fd43dcf88f835e2508b4eac67e5b250242cbef63
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-17T19:20:24Z

    TINKERPOP3-639 Fix SelectStep/SelectOneStep Generic signature

commit 64224ff2a13ede44acfa451274b8cae888728fe1
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-17T19:20:53Z

    TINKERPOP3-639 Add selectList step

commit e7ac765442f16fb999bef2f894bcc7d4066f947c
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-17T19:24:26Z

    TINKERPOP3-639 Add SelectTest tests for 'select last' behavior
    
    These tests define the desired behavior as of #639, namely, that 'select' should never produce a List, but should
    instead produce the value from the most recently traversed step matching the specified label(s).

commit 1168f901698e8c309931868427a944927ad5c211
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-17T19:32:51Z

    TINKERPOP3-639 Change ignore explanation of select-across-barrier unit test

commit cfa34e8fe015527cbeb0124653d2a3aee0cea74d
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-17T20:31:52Z

    TINKERPOP3-639 Change 'select' to use Path.getLast

commit ac9f208af73a29e7c4841623f91c7ad33cc3b1e6
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-22T16:14:47Z

    TINKERPOP3-639 Add selectList to __

commit ae82bee1606ab257b2422d8f73f314f391bfc23e
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-22T18:18:18Z

    TINKERPOP3-639 Disable g_V_asXaX_out_asXaX_out_asXaX_selectXaX_byXnameX for COMPUTER

commit aa3b10000119a78ca5c8a2d1e65c8c1e4c10d9ae
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-22T21:35:09Z

    TINKERPOP3-639 Ignore certain selectList tests for COMPUTER
    
    The common failure observed in these tests was the presence of Vertex objects that had no properties.  In some cases,
    these objects appear during application of the "by" traversal, while for others, they appear when iterating through the
    results.

commit af6458edfecbd948e4722348b4b2caf1bf953a5e
Author: mhfrantz <mf...@redsealnetworks.com>
Date:   2015-04-22T23:03:29Z

    Add integration/performance test running details to README

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-639 selectList (v4)

Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/56#discussion_r28986964
  
    --- Diff: gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovySelectListTest.groovy ---
    @@ -0,0 +1,340 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.tinkerpop.gremlin.process.traversal.step.map
    +
    +import org.apache.tinkerpop.gremlin.process.computer.ComputerTestHelper
    +import org.apache.tinkerpop.gremlin.process.traversal.Traversal
    +import org.apache.tinkerpop.gremlin.process.traversal.TraversalEngine
    +import org.apache.tinkerpop.gremlin.process.UseEngine
    +import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__
    +import org.apache.tinkerpop.gremlin.structure.Edge
    +import org.apache.tinkerpop.gremlin.structure.Order
    +import org.apache.tinkerpop.gremlin.structure.Vertex
    +import org.junit.Test
    +
    +import static __.values
    +
    +/**
    + * @author Marko A. Rodriguez (http://markorodriguez.com)
    + */
    +public abstract class GroovySelectListTest {
    +
    +    @UseEngine(TraversalEngine.Type.STANDARD)
    +    public static class StandardTraversals extends SelectListTest {
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Vertex>>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectList(final Object v1Id) {
    +            g.V(v1Id).as('a').out('knows').as('b').selectList()
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<String>>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectList_byXnameX(
    +                final Object v1Id) {
    +            g.V(v1Id).as('a').out('knows').as('b').selectList.by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<Vertex>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectListXaX(final Object v1Id) {
    +            g.V(v1Id).as('a').out('knows').as('b').selectList('a')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<String>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectListXaX_byXnameX(
    +                final Object v1Id) {
    +            g.V(v1Id).as('a').out('knows').as('b').selectList('a').by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<String>>> get_g_V_asXaX_out_asXbX_selectList_byXnameX() {
    +            g.V.as('a').out.as('b').selectList.by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<String>>> get_g_V_asXaX_out_aggregateXxX_asXbX_selectList_byXnameX() {
    +            g.V.as('a').out.aggregate('x').as('b').selectList.by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<String>>> get_g_V_asXaX_name_order_asXbX_selectList_byXnameX_by_XitX() {
    +            g.V().as('a').name.order().as('b').selectList.by('name').by
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Object>>> get_g_V_hasXname_gremlinX_inEXusesX_order_byXskill_incrX_asXaX_outV_asXbX_selectList_byXskillX_byXnameX() {
    +            g.V.has('name', 'gremlin').inE('uses').order.by('skill', Order.incr).as('a').outV.as('b').selectList.by('skill').by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Object>>> get_g_V_hasXname_isXmarkoXX_asXaX_selectList() {
    +            return g.V.has(values('name').is('marko')).as('a').selectList
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Map<String, Long>>>> get_g_V_label_groupCount_asXxX_selectList() {
    +            return g.V().label().groupCount().as('x').selectList()
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Object>>> get_g_V_hasLabelXpersonX_asXpersonX_localXbothE_label_groupCountX_asXrelationsX_selectList_byXnameX_by() {
    +            return g.V().hasLabel('person').as('person').local(__.bothE().label().groupCount()).as('relations').selectList().by('name').by()
    +        }
    +
    +        // WIP
    --- End diff --
    
    remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-639 selectList (v4)

Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/56#issuecomment-95757467
  
    Replaced by #57


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-639 selectList (v4)

Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/56


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-639 selectList (v4)

Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/56#discussion_r28987584
  
    --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Path.java ---
    @@ -89,6 +89,47 @@ public default int size() {
         }
     
         /**
    +     * Get the object most recently associated with the particular label of the path.
    +     *
    +     * @param label the label of the path
    +     * @param <A>   the type of the object associated with the label
    +     * @return the object associated with the label of the path
    +     * @throws IllegalArgumentException if the path does not contain the label
    +     */
    +    public default <A> A getLast(final String label) throws IllegalArgumentException {
    +        final List<Object> objects = this.objects();
    +        final List<Set<String>> labels = this.labels();
    +        for (int i = 0; i < labels.size(); i++) {
    --- End diff --
    
    fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-639 selectList (v4)

Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/56#issuecomment-95740242
  
    I will go ahead and rebase, since the removal of `SparsePath` will cause merge conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-639 selectList (v4)

Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/56#discussion_r28986981
  
    --- Diff: gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovySelectListTest.groovy ---
    @@ -0,0 +1,340 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.tinkerpop.gremlin.process.traversal.step.map
    +
    +import org.apache.tinkerpop.gremlin.process.computer.ComputerTestHelper
    +import org.apache.tinkerpop.gremlin.process.traversal.Traversal
    +import org.apache.tinkerpop.gremlin.process.traversal.TraversalEngine
    +import org.apache.tinkerpop.gremlin.process.UseEngine
    +import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__
    +import org.apache.tinkerpop.gremlin.structure.Edge
    +import org.apache.tinkerpop.gremlin.structure.Order
    +import org.apache.tinkerpop.gremlin.structure.Vertex
    +import org.junit.Test
    +
    +import static __.values
    +
    +/**
    + * @author Marko A. Rodriguez (http://markorodriguez.com)
    + */
    +public abstract class GroovySelectListTest {
    +
    +    @UseEngine(TraversalEngine.Type.STANDARD)
    +    public static class StandardTraversals extends SelectListTest {
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Vertex>>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectList(final Object v1Id) {
    +            g.V(v1Id).as('a').out('knows').as('b').selectList()
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<String>>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectList_byXnameX(
    +                final Object v1Id) {
    +            g.V(v1Id).as('a').out('knows').as('b').selectList.by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<Vertex>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectListXaX(final Object v1Id) {
    +            g.V(v1Id).as('a').out('knows').as('b').selectList('a')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<String>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectListXaX_byXnameX(
    +                final Object v1Id) {
    +            g.V(v1Id).as('a').out('knows').as('b').selectList('a').by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<String>>> get_g_V_asXaX_out_asXbX_selectList_byXnameX() {
    +            g.V.as('a').out.as('b').selectList.by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<String>>> get_g_V_asXaX_out_aggregateXxX_asXbX_selectList_byXnameX() {
    +            g.V.as('a').out.aggregate('x').as('b').selectList.by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<String>>> get_g_V_asXaX_name_order_asXbX_selectList_byXnameX_by_XitX() {
    +            g.V().as('a').name.order().as('b').selectList.by('name').by
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Object>>> get_g_V_hasXname_gremlinX_inEXusesX_order_byXskill_incrX_asXaX_outV_asXbX_selectList_byXskillX_byXnameX() {
    +            g.V.has('name', 'gremlin').inE('uses').order.by('skill', Order.incr).as('a').outV.as('b').selectList.by('skill').by('name')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Object>>> get_g_V_hasXname_isXmarkoXX_asXaX_selectList() {
    +            return g.V.has(values('name').is('marko')).as('a').selectList
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Map<String, Long>>>> get_g_V_label_groupCount_asXxX_selectList() {
    +            return g.V().label().groupCount().as('x').selectList()
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Object>>> get_g_V_hasLabelXpersonX_asXpersonX_localXbothE_label_groupCountX_asXrelationsX_selectList_byXnameX_by() {
    +            return g.V().hasLabel('person').as('person').local(__.bothE().label().groupCount()).as('relations').selectList().by('name').by()
    +        }
    +
    +        // WIP
    +
    +        @Override
    +        public Traversal<Vertex, List<Vertex>> get_g_V_asXaX_out_asXaX_out_asXaX_selectListXaX() {
    +            return g.V().as("a").out().as("a").out().as("a").selectList("a");
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<String>> get_g_V_asXaX_out_asXaX_out_asXaX_selectListXaX_byXnameX() {
    +            return g.V().as("a").out().as("a").out().as("a").<String>selectList("a").by("name");
    +        }
    +
    +        //
    +
    +        @Override
    +        public Traversal<Vertex, List<Vertex>> get_g_VX1X_asXhereX_out_selectListXhereX(final Object v1Id) {
    +            g.V(v1Id).as('here').out.selectList('here')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<Vertex>> get_g_VX4X_out_asXhereX_hasXlang_javaX_selectListXhereX(final Object v4Id) {
    +            g.V(v4Id).out.as('here').has('lang', 'java').selectList('here')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, String> get_g_VX4X_out_asXhereX_hasXlang_javaX_selectListXhereX_unfold_name(
    +                final Object v4Id) {
    +            g.V(v4Id).out.as('here').has('lang', 'java').selectList('here').unfold().name
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<Edge>> get_g_VX1X_outE_asXhereX_inV_hasXname_vadasX_selectListXhereX(final Object v1Id) {
    +            g.V(v1Id).outE.as('here').inV.has('name', 'vadas').selectList('here')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<Edge>> get_g_VX1X_outEXknowsX_hasXweight_1X_asXhereX_inV_hasXname_joshX_selectListXhereX(
    +                final Object v1Id) {
    +            g.V(v1Id).outE('knows').has('weight', 1.0d).as('here').inV.has('name', 'josh').selectList('here')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<Edge>> get_g_VX1X_outEXknowsX_asXhereX_hasXweight_1X_inV_hasXname_joshX_selectListXhereX(
    +                final Object v1Id) {
    +            g.V(v1Id).outE('knows').as('here').has('weight', 1.0d).inV.has('name', 'josh').selectList('here')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<Edge>> get_g_VX1X_outEXknowsX_asXhereX_hasXweight_1X_asXfakeX_inV_hasXname_joshX_selectListXhereX(
    +                final Object v1Id) {
    +            g.V(v1Id).outE("knows").as('here').has('weight', 1.0d).as('fake').inV.has("name", 'josh').selectList('here')
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<Vertex>> get_g_V_asXhereXout_name_selectListXhereX() {
    +            g.V().as("here").out.name.selectList("here");
    +        }
    +
    +
    +        @Override
    +        public Traversal<Vertex, Map<List<String>, Long>> get_g_V_outXcreatedX_unionXasXprojectX_inXcreatedX_hasXname_markoX_selectListXprojectX__asXprojectX_inXcreatedX_inXknowsX_hasXname_markoX_selectListXprojectXX_groupCount_byXnameX() {
    +            g.V.out('created')
    +                    .union(__.as('project').in('created').has('name', 'marko').selectList('project'),
    +                    __.as('project').in('created').in('knows').has('name', 'marko').selectList('project')).groupCount().by('name');
    +        }
    +    }
    +
    +    @UseEngine(TraversalEngine.Type.COMPUTER)
    +    public static class ComputerTraversals extends SelectListTest {
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Vertex>>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectList(final Object v1Id) {
    +            ComputerTestHelper.compute("g.V(${v1Id}).as('a').out('knows').as('b').selectList()", g);
    +        }
    +
    +        @Override
    +        @Test
    +        @org.junit.Ignore("Traversal not supported by ComputerTraversalEngine.computer")
    +        public void g_VX1X_asXaX_outXknowsX_asXbX_selectList_byXnameX() {
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, List<Vertex>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectListXaX(final Object v1Id) {
    +            ComputerTestHelper.compute("g.V(${v1Id}).as('a').out('knows').as('b').selectList('a')", g);
    +        }
    +
    +        @Override
    +        @Test
    +        @org.junit.Ignore("Traversal not supported by ComputerTraversalEngine.computer")
    +        public void g_VX1X_asXaX_outXknowsX_asXbX_selectListXaX_byXnameX() {
    +        }
    +
    +        @Override
    +        @Test
    +        @org.junit.Ignore("Traversal not supported by ComputerTraversalEngine.computer")
    +        public void g_V_asXaX_out_asXbX_selectList_byXnameX() {
    +        }
    +
    +        @Override
    +        @Test
    +        @org.junit.Ignore("Traversal not supported by ComputerTraversalEngine.computer")
    +        public void g_V_asXaX_name_order_asXbX_selectList_byXnameX_byXitX() {
    +        }
    +
    +        @Override
    +        @Test
    +        @org.junit.Ignore("Traversal not supported by ComputerTraversalEngine.computer")
    +        public void g_V_hasXname_gremlinX_inEXusesX_order_byXskill_incrX_asXaX_outV_asXbX_selectList_byXskillX_byXnameX() {
    +        }
    +
    +        @Override
    +        public Traversal<Vertex, Map<String, List<Object>>> get_g_V_hasXname_isXmarkoXX_asXaX_selectList() {
    +            ComputerTestHelper.compute("g.V.has(values('name').is('marko')).as('a').selectList", g)
    +        }
    +
    +        @Override
    +        @Test
    +        @org.junit.Ignore("Traversal not supported by ComputerTraversalEngine.computer")
    +        public void g_V_label_groupCount_asXxX_selectList() {
    +        }
    +
    +        @Override
    +        @Test
    +        @org.junit.Ignore("Traversal not supported by ComputerTraversalEngine.computer")
    +        void g_V_hasLabelXpersonX_asXpersonX_localXbothE_label_groupCountX_asXrelationsX_selectList_byXnameX_by() {
    +        }
    +
    +        @Override
    +        Traversal<Vertex, Map<String, List<String>>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectList_byXnameX(Object v1Id) {
    +            // override with nothing until the test itself is supported
    +            return null
    +        }
    +
    +        @Override
    +        Traversal<Vertex, List<String>> get_g_VX1X_asXaX_outXknowsX_asXbX_selectListXaX_byXnameX(Object v1Id) {
    +            // override with nothing until the test itself is supported
    +            return null
    +        }
    +
    +        @Override
    +        Traversal<Vertex, Map<String, List<String>>> get_g_V_asXaX_out_asXbX_selectList_byXnameX() {
    +            // override with nothing until the test itself is supported
    +            return null
    +        }
    +
    +        @Override
    +        Traversal<Vertex, Map<String, List<String>>> get_g_V_asXaX_out_aggregateXxX_asXbX_selectList_byXnameX() {
    +            // override with nothing until the test itself is supported
    +            return null
    +        }
    +
    +        @Override
    +        Traversal<Vertex, Map<String, List<String>>> get_g_V_asXaX_name_order_asXbX_selectList_byXnameX_by_XitX() {
    +            // override with nothing until the test itself is supported
    +            return null
    +        }
    +
    +        @Override
    +        Traversal<Vertex, Map<String, List<Object>>> get_g_V_hasXname_gremlinX_inEXusesX_order_byXskill_incrX_asXaX_outV_asXbX_selectList_byXskillX_byXnameX() {
    +            // override with nothing until the test itself is supported
    +            return null
    +        }
    +
    +        @Override
    +        Traversal<Vertex, Map<String, List<Map<String, Long>>>> get_g_V_label_groupCount_asXxX_selectList() {
    +            // override with nothing until the test itself is supported
    +            return null
    +        }
    +
    +        @Override
    +        Traversal<Vertex, Map<String, List<Object>>> get_g_V_hasLabelXpersonX_asXpersonX_localXbothE_label_groupCountX_asXrelationsX_selectList_byXnameX_by() {
    +            // override with nothing until the test itself is supported
    +            return null
    +        }
    +
    +        // WIP
    --- End diff --
    
    remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-639 selectList (v4)

Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/56#issuecomment-95674173
  
    @dkuppitz I pushed fixups for the issues you mentioned in the JIRA ticket.  When you're happy with this PR, I will rebase.
    
    https://issues.apache.org/jira/browse/TINKERPOP3-639?focusedCommentId=14509253&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14509253
    
    Was the comment about "a TBD in the description" referring to the "WIP" comments that I have just removed?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---