You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/08 09:22:56 UTC

[GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #537: [IOTDB-220]Add hot-load configuration function

fanhualta commented on a change in pull request #537: [IOTDB-220]Add hot-load configuration function
URL: https://github.com/apache/incubator-iotdb/pull/537#discussion_r344077181
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/qp/executor/QueryProcessExecutor.java
 ##########
 @@ -130,13 +130,16 @@ public boolean processNonQuery(PhysicalPlan plan) throws ProcessorException {
       case SET_STORAGE_GROUP:
         return setStorageGroup((SetStorageGroupPlan) plan);
       case DELETE_STORAGE_GROUP:
-        return deleteStorageGroup((DeleteStorageGroupPlan) plan);  
+        return deleteStorageGroup((DeleteStorageGroupPlan) plan);
       case PROPERTY:
         PropertyPlan property = (PropertyPlan) plan;
         return operateProperty(property);
       case TTL:
         operateTTL((SetTTLPlan) plan);
         return true;
+      case LOAD_CONFIGURATION:
+        IoTDBDescriptor.getInstance().loadHotModifiedProps();
 
 Review comment:
   These parameters need to be updated by the user, so I will update all parameters until I encounter a wrong parameter. In the scenario you described, is there any problem? Equivalent to that the user only updated `tsfile_size_threshold = 100`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services