You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Lucian Adrian Grijincu <lu...@gmail.com> on 2008/04/15 16:58:40 UTC
Re: apr_os_dir_put fixes
We discussed in this[1] thread has discussed the problem, patches were
sent, a bug[2] was filled.
Was this issue fixed and I missed the commit, or was it forgotten :) ?
[1] http://www.mail-archive.com/dev@apr.apache.org/msg19497.html
[2] https://issues.apache.org/bugzilla/show_bug.cgi?id=44129
Shouldn't this go in 1.3.x before the release?
And for that matter in trunk/ also?
--
Lucian
Re: apr_os_dir_put fixes
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Tue, Apr 15, 2008 at 6:07 PM, William A. Rowe, Jr.
<wr...@rowe-clan.net> wrote:
>
> Lucian Adrian Grijincu wrote:
>
> > We discussed in this[1] thread has discussed the problem, patches were
> > sent, a bug[2] was filled.
> >
> > Was this issue fixed and I missed the commit, or was it forgotten :) ?
> >
> > [1] http://www.mail-archive.com/dev@apr.apache.org/msg19497.html
> > [2] https://issues.apache.org/bugzilla/show_bug.cgi?id=44129
> >
> > Shouldn't this go in 1.3.x before the release?
> > And for that matter in trunk/ also?
> >
>
> Righto... first patch broke the ABI rule, attached to 44129 resolved this
> issue for trunk/1.3.x.
>
> I'm not able to now, hopefully someone else can so there is extra review
> (I'd commit just before rolling 1.3.0 - it looks right, but can't now).
I see William is sweeping through the bugzilla, so I'm bumping this once more.
--
Lucian
Re: apr_os_dir_put fixes
Posted by Lucian Adrian Grijincu <lu...@gmail.com>.
On Tue, Apr 15, 2008 at 6:07 PM, William A. Rowe, Jr.
<wr...@rowe-clan.net> wrote:
> Lucian Adrian Grijincu wrote:
>>
>> We discussed in this[1] thread has discussed the problem, patches were
>> sent, a bug[2] was filled.
>>
>> Was this issue fixed and I missed the commit, or was it forgotten :) ?
>>
>> [1] http://www.mail-archive.com/dev@apr.apache.org/msg19497.html
>> [2] https://issues.apache.org/bugzilla/show_bug.cgi?id=44129
>>
>> Shouldn't this go in 1.3.x before the release?
>> And for that matter in trunk/ also?
>
> Righto... first patch broke the ABI rule, attached to 44129 resolved this
> issue for trunk/1.3.x.
>
> I'm not able to now, hopefully someone else can so there is extra review
> (I'd commit just before rolling 1.3.0 - it looks right, but can't now).
>
William, or anyone else for that matter, could you have a last look at this?
This patch is in dire need of some commiter love.
The last change (apart from the taging) on 1.3.x's unix/dir.c was way
before the patch was commited so this should fit perfectly.
--
Lucian
Re: apr_os_dir_put fixes
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Lucian Adrian Grijincu wrote:
> We discussed in this[1] thread has discussed the problem, patches were
> sent, a bug[2] was filled.
>
> Was this issue fixed and I missed the commit, or was it forgotten :) ?
>
> [1] http://www.mail-archive.com/dev@apr.apache.org/msg19497.html
> [2] https://issues.apache.org/bugzilla/show_bug.cgi?id=44129
>
> Shouldn't this go in 1.3.x before the release?
> And for that matter in trunk/ also?
Righto... first patch broke the ABI rule, attached to 44129 resolved this
issue for trunk/1.3.x.
I'm not able to now, hopefully someone else can so there is extra review
(I'd commit just before rolling 1.3.0 - it looks right, but can't now).