You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "KoviAnusha (via GitHub)" <gi...@apache.org> on 2025/10/26 04:57:23 UTC
[PR] Fix MyPy type errors in /api_fastapi/execution_api/ dag_runs.py,task_instances.py for Sqlalchemy 2 migration [airflow]
KoviAnusha opened a new pull request, #57277:
URL: https://github.com/apache/airflow/pull/57277
related: #56735
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #56735
related: #56735
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Worked on fixing mypy errors in
1. airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
2. airflow-core/src/airflow/api_fastapi/execution_api/routes/dag_runs.py
that include
1. Fixed None argument to get_dag_for_run
2. Result.rowcount attribute errors
3. Query variable type mismatch
4. session.bind None
5. TaskInstance None
6. TaskReschedule UUID type issue
7. session.execute().fetchone() None handling
8. Task inlets/outlets None handling
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MyPy type errors /api_fastapi/execution_api/,/airflow/jobs/, /airflow/models/ in Sqlalchemy 2 migration [airflow]
Posted by "KoviAnusha (via GitHub)" <gi...@apache.org>.
KoviAnusha commented on code in PR #57277:
URL: https://github.com/apache/airflow/pull/57277#discussion_r2463922196
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -340,7 +340,8 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session) -
executable_tis: list[TI] = []
- if session.get_bind().dialect.name == "postgresql":
+ bind = session.get_bind()
+ if bind is not None and bind.dialect.name == "postgresql":
Review Comment:
Thanks for letting me know @kaxil @Dev-iL. I have worked on it and pushed the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MyPy type errors /api_fastapi/execution_api/,/airflow/jobs/, /airflow/models/ in Sqlalchemy 2 migration [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #57277:
URL: https://github.com/apache/airflow/pull/57277#discussion_r2463814233
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -340,7 +340,8 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session) -
executable_tis: list[TI] = []
- if session.get_bind().dialect.name == "postgresql":
+ bind = session.get_bind()
+ if bind is not None and bind.dialect.name == "postgresql":
Review Comment:
there is a `get_dialect_name` func in one of the utils module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MyPy type errors /api_fastapi/execution_api/,/airflow/jobs/, /airflow/models/ in Sqlalchemy 2 migration [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #57277:
URL: https://github.com/apache/airflow/pull/57277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MyPy type errors /api_fastapi/execution_api/,/airflow/jobs/, /airflow/models/ in Sqlalchemy 2 migration [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on PR #57277:
URL: https://github.com/apache/airflow/pull/57277#issuecomment-3448729121
> > Looks like I worked on `scheduler_job_runner.py` too in #57278. Interestingly, my (AI's) solutions are completely different for almost everything
>
> Isn't my thought process/approach right?
I didn't say that! I'm just "academically intrigued" that it was possible. One would think that solution to the same problem would be similar.
One difference I noticed is my own changes were more focused on adjusting types and hints whereas yours modified the logic in small ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MyPy type errors /api_fastapi/execution_api/,/airflow/jobs/, /airflow/models/ in Sqlalchemy 2 migration [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on PR #57277:
URL: https://github.com/apache/airflow/pull/57277#issuecomment-3448519374
Looks like I worked on `scheduler_job_runner.py` too in https://github.com/apache/airflow/pull/57278. Interestingly, my (AI's) solutions are completely different for almost everything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MyPy type errors /api_fastapi/execution_api/,/airflow/jobs/, /airflow/models/ in Sqlalchemy 2 migration [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on code in PR #57277:
URL: https://github.com/apache/airflow/pull/57277#discussion_r2463816685
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -340,7 +340,8 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session) -
executable_tis: list[TI] = []
- if session.get_bind().dialect.name == "postgresql":
+ bind = session.get_bind()
+ if bind is not None and bind.dialect.name == "postgresql":
Review Comment:
It's in `airflow-core/src/airflow/utils/sqlalchemy.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix MyPy type errors /api_fastapi/execution_api/,/airflow/jobs/, /airflow/models/ in Sqlalchemy 2 migration [airflow]
Posted by "KoviAnusha (via GitHub)" <gi...@apache.org>.
KoviAnusha commented on PR #57277:
URL: https://github.com/apache/airflow/pull/57277#issuecomment-3448699409
> Looks like I worked on `scheduler_job_runner.py` too in #57278. Interestingly, my (AI's) solutions are completely different for almost everything
Isn't my thought process/approach right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org