[GitHub] [apisix] biubiue commented on a diff in pull request #7782: feat(kafka-logger): support sasl conf

[GitBox <gi...@apache.org>]

biubiue commented on code in PR #7782:
URL: https://github.com/apache/apisix/pull/7782#discussion_r964418667


##########
t/plugin/kafka-logger.t:
##########
@@ -592,3 +592,44 @@ qr/partition_id: 2/]
 [qr/partition_id: 1/,
 qr/partition_id: 0/,
 qr/partition_id: 2/]
+
+
+
+=== TEST 20: user sasl create producer
+--- extra_init_by_lua
+local producer = require("resty.kafka.producer")
+producer.send = function()
+    return true
+end
+--- config
+    location /t {
+        content_by_lua_block {
+            local producer = require "resty.kafka.producer"

Review Comment:
   > We should test the kafka-logger plugin directly like other tests, instead of using the producer outside of the plugin.
   
   Em... I maybe not understand [https://github.com/apache/apisix/pull/7782#discussion_r956718372](url) .
   OK, I will add test case like others



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org