You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/08/17 16:40:36 UTC
[GitHub] [dolphinscheduler] allen1128 opened a new pull request #5997: [Improvement][Dao] SQL optimization - check exist #5930 #5931
allen1128 opened a new pull request #5997:
URL: https://github.com/apache/dolphinscheduler/pull/5997
Purpose of the pull request
See [#5061](https://github.com/apache/dolphinscheduler/issues/5061)
this closes [#5930](https://github.com/apache/dolphinscheduler/issues/5930)
Brief change log
Using select 1 from xx limit 1 to check the record exist.
Verify this pull request
Add Unit test for each changed mapper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] allen1128 closed pull request #5997: [Improvement][Dao] SQL optimization - check exist #5930 #5931
Posted by GitBox <gi...@apache.org>.
allen1128 closed pull request #5997:
URL: https://github.com/apache/dolphinscheduler/pull/5997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on pull request #5997: [Improvement][Dao] SQL optimization - check exist #5930 #5931
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #5997:
URL: https://github.com/apache/dolphinscheduler/pull/5997#issuecomment-900882853
looks good, thx for your contribution, can you resolve check style err? you can refer this :https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] allen1128 commented on pull request #5997: [Improvement][Dao] SQL optimization - check exist #5930 #5931
Posted by GitBox <gi...@apache.org>.
allen1128 commented on pull request #5997:
URL: https://github.com/apache/dolphinscheduler/pull/5997#issuecomment-901242322
> looks good, thx for your contribution, can you resolve check style err? you can refer this :https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
sure. it's resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] allen1128 commented on pull request #5997: [Improvement][Dao] SQL optimization - check exist #5930 #5931
Posted by GitBox <gi...@apache.org>.
allen1128 commented on pull request #5997:
URL: https://github.com/apache/dolphinscheduler/pull/5997#issuecomment-901242322
> looks good, thx for your contribution, can you resolve check style err? you can refer this :https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
sure. it's resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on pull request #5997: [Improvement][Dao] SQL optimization - check exist #5930 #5931
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #5997:
URL: https://github.com/apache/dolphinscheduler/pull/5997#issuecomment-900882853
looks good, thx for your contribution, can you resolve check style err? you can refer this :https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org