[jira] [Commented] (BEAM-745) Display Data fails on transforms with nested components of the same type

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15592567#comment-15592567 ] 

ASF GitHub Bot commented on BEAM-745:
-------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1088


> Display Data fails on transforms with nested components of the same type
> ------------------------------------------------------------------------
>
>                 Key: BEAM-745
>                 URL: https://issues.apache.org/jira/browse/BEAM-745
>             Project: Beam
>          Issue Type: Bug
>            Reporter: Scott Wegner
>            Assignee: Scott Wegner
>
> Display Data supports the notion of "sub components", components within a transform class which can contribute their own display data. We add a namespace to display data items based on the originating component, which keeps the display data items unique within the step.
> There are instances where a component is included multiple times within a step. We handle the case of the same instance being shared by simply ignoring it the second time. However, we don't handle the case of a separate instance being added of the same class. Currently the separate instances will add display data with the same namespace and key, causing a failure.
> This can come up for example when infrastructure at different levels wrap and re-wrap a component. We saw this with a bounded source being adapted multiple times, Bounded -> Unbounded -> Bounded -> Unbounded. The BoundedToUnboundedSourceAdapter was included multiple times with separate instances and caused a failure while populating display data.
> See: https://github.com/apache/incubator-beam/pull/1088 for a failing test case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)