You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Ruby Boyarski (JIRA)" <ji...@apache.org> on 2010/10/06 01:56:38 UTC
[jira] Created: (WINK-316) AdminServlet doesn't process QueryParams
properly
AdminServlet doesn't process QueryParams properly
-------------------------------------------------
Key: WINK-316
URL: https://issues.apache.org/jira/browse/WINK-316
Project: Wink
Issue Type: Bug
Components: Server
Affects Versions: 1.1.1
Reporter: Ruby Boyarski
Priority: Minor
The AdminServlet doesn't include parameters of type QueryParam in its output.
The reason is that the code to do that uses MatrixParam instead.
The method buildQueryParams handles query params and instead of checking for QueryParam it's checking for MatrixParam (the problem is the "==injectable.ParamType.*MATRIX*").
Here is the fixed method:
{code}
private void buildQueryParams(MethodMetadata methodMetadata, QueryParameters xmlQueryVariables) {
List<Injectable> formalParameters = methodMetadata.getFormalParameters();
for (Injectable var : formalParameters) {
if (var.getParamType() == Injectable.ParamType.QUERY) {
Parameter param = resourcesObjectFactory.createParameter();
param.setValue(((BoundInjectable)var).getName());
xmlQueryVariables.getParameter().add(param);
}
}
}
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-316) AdminServlet doesn't process
QueryParams properly
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk resolved WINK-316.
-----------------------------
Resolution: Fixed
Fix Version/s: 1.1.2
Assignee: Bryant Luk
Patch looks good to me so I went ahead and applied it. Thanks for the patch.
> AdminServlet doesn't process QueryParams properly
> -------------------------------------------------
>
> Key: WINK-316
> URL: https://issues.apache.org/jira/browse/WINK-316
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.1.1
> Reporter: Ruby Boyarski
> Assignee: Bryant Luk
> Priority: Minor
> Fix For: 1.1.2
>
> Attachments: AdminServlet.java
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The AdminServlet doesn't include parameters of type QueryParam in its output.
> The reason is that the code to do that uses MatrixParam instead.
> The method buildQueryParams handles query params and instead of checking for QueryParam it's checking for MatrixParam (the problem is the "==injectable.ParamType.*MATRIX*").
> Here is the fixed method:
> {code}
> private void buildQueryParams(MethodMetadata methodMetadata, QueryParameters xmlQueryVariables) {
> List<Injectable> formalParameters = methodMetadata.getFormalParameters();
> for (Injectable var : formalParameters) {
> if (var.getParamType() == Injectable.ParamType.QUERY) {
> Parameter param = resourcesObjectFactory.createParameter();
> param.setValue(((BoundInjectable)var).getName());
> xmlQueryVariables.getParameter().add(param);
> }
> }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-316) AdminServlet doesn't process QueryParams
properly
Posted by "Ruby Boyarski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruby Boyarski updated WINK-316:
-------------------------------
Patch Info: [Patch Available]
> AdminServlet doesn't process QueryParams properly
> -------------------------------------------------
>
> Key: WINK-316
> URL: https://issues.apache.org/jira/browse/WINK-316
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.1.1
> Reporter: Ruby Boyarski
> Priority: Minor
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The AdminServlet doesn't include parameters of type QueryParam in its output.
> The reason is that the code to do that uses MatrixParam instead.
> The method buildQueryParams handles query params and instead of checking for QueryParam it's checking for MatrixParam (the problem is the "==injectable.ParamType.*MATRIX*").
> Here is the fixed method:
> {code}
> private void buildQueryParams(MethodMetadata methodMetadata, QueryParameters xmlQueryVariables) {
> List<Injectable> formalParameters = methodMetadata.getFormalParameters();
> for (Injectable var : formalParameters) {
> if (var.getParamType() == Injectable.ParamType.QUERY) {
> Parameter param = resourcesObjectFactory.createParameter();
> param.setValue(((BoundInjectable)var).getName());
> xmlQueryVariables.getParameter().add(param);
> }
> }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-316) AdminServlet doesn't process
QueryParams properly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918584#action_12918584 ]
Hudson commented on WINK-316:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #390 (See [https://hudson.apache.org/hudson/job/Wink-Trunk-JDK1.5/390/])
Fix AdminServlet to process query parameters correctly
See [WINK-316]
Thanks to Ruby Boyarski for reporting the issue
and the patch.
> AdminServlet doesn't process QueryParams properly
> -------------------------------------------------
>
> Key: WINK-316
> URL: https://issues.apache.org/jira/browse/WINK-316
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.1.1
> Reporter: Ruby Boyarski
> Assignee: Bryant Luk
> Priority: Minor
> Fix For: 1.1.2
>
> Attachments: AdminServlet.java
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The AdminServlet doesn't include parameters of type QueryParam in its output.
> The reason is that the code to do that uses MatrixParam instead.
> The method buildQueryParams handles query params and instead of checking for QueryParam it's checking for MatrixParam (the problem is the "==injectable.ParamType.*MATRIX*").
> Here is the fixed method:
> {code}
> private void buildQueryParams(MethodMetadata methodMetadata, QueryParameters xmlQueryVariables) {
> List<Injectable> formalParameters = methodMetadata.getFormalParameters();
> for (Injectable var : formalParameters) {
> if (var.getParamType() == Injectable.ParamType.QUERY) {
> Parameter param = resourcesObjectFactory.createParameter();
> param.setValue(((BoundInjectable)var).getName());
> xmlQueryVariables.getParameter().add(param);
> }
> }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-316) AdminServlet doesn't process QueryParams
properly
Posted by "Ruby Boyarski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruby Boyarski updated WINK-316:
-------------------------------
Attachment: AdminServlet.java
> AdminServlet doesn't process QueryParams properly
> -------------------------------------------------
>
> Key: WINK-316
> URL: https://issues.apache.org/jira/browse/WINK-316
> Project: Wink
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.1.1
> Reporter: Ruby Boyarski
> Priority: Minor
> Attachments: AdminServlet.java
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The AdminServlet doesn't include parameters of type QueryParam in its output.
> The reason is that the code to do that uses MatrixParam instead.
> The method buildQueryParams handles query params and instead of checking for QueryParam it's checking for MatrixParam (the problem is the "==injectable.ParamType.*MATRIX*").
> Here is the fixed method:
> {code}
> private void buildQueryParams(MethodMetadata methodMetadata, QueryParameters xmlQueryVariables) {
> List<Injectable> formalParameters = methodMetadata.getFormalParameters();
> for (Injectable var : formalParameters) {
> if (var.getParamType() == Injectable.ParamType.QUERY) {
> Parameter param = resourcesObjectFactory.createParameter();
> param.setValue(((BoundInjectable)var).getName());
> xmlQueryVariables.getParameter().add(param);
> }
> }
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.