You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by "pepness (via GitHub)" <gi...@apache.org> on 2023/10/06 19:30:23 UTC

[PR] Add support for GlassFish 7.0.6, 7.0.7, and 7.0.9 [netbeans]

pepness opened a new pull request, #6542:
URL: https://github.com/apache/netbeans/pull/6542

   Library Notes:
   
   - Add support for Java 21
   - Refactoring and maintenance of code base
   - Fix processing of the Multi-Release libraries in EAR application
   - Bug fixes and updates of various components
   
   NetBeans GlassFish module notes:
   
   - Add support for GlassFish version 7.0.7, 7.0.8, and 7.0.9
   - Add new ConfigBuilderProvider for GlassFish 7.0.9 and newer versions that support Java 21
   - Add support for JavaSE constants up to version 22
   - Bump `javac.source` and `javac.target` to version 11 for all 4 GlassFish modules `common`, `eecommon`, `javaee`, and `tooling`
   - Refactor creation of `ServerWizardIterator` with one private array
   - Remove some unnecessary imports
   - Make final some fields
   - Refactor long switch statement to one `if if-else else` statement
   - Use ConcurrentMap for `builders`, set initial capacity, use atomic operations `computeIfPresent` and `computeIfAbsent`, and remove some synchronized blocks because the ConcurrentHashMap implementation already use synchronized at a field level
   
   NetBeans Testing:
   
   - Verify successful execution of libraries and licenses Ant test
   - Verify successful execution of Verify Sigtests
   - Verify successful execution of `ant -Dcluster.config=release commit-validation`
   - Verify successful execution of unit tests for modules `glassfish.common`, `glassfish.javaee`, `glassfish.tooling`, and `glassfish.eecommon`
   - Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
   - Successfully register GlassFish 7.0.7, 7.0.8, and 7.0.9, create a web app and verify that it works.
   
   [Release Notes](https://github.com/eclipse-ee4j/glassfish/releases/tag/7.0.9)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Add support for GlassFish 7.0.6, 7.0.7, and 7.0.9 [netbeans]

Posted by "pepness (via GitHub)" <gi...@apache.org>.

pepness commented on code in PR #6542:
URL: https://github.com/apache/netbeans/pull/6542#discussion_r1353708741


##########
enterprise/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/ConfigBuilderProvider.java:
##########
@@ -193,16 +209,13 @@ public static ConfigBuilder getBuilder(final GlassFishServer server) {
                     "GlassFish server entity shall not be null");
         }
         ConfigBuilder builder;
-        synchronized (builders) {
-            builder = builders.get(server);
-            if (builder != null) {
-                return builder;
-            }
-            String serverHome = server.getServerHome();
-            builder = new ConfigBuilder(config, serverHome, serverHome, serverHome);
-            builders.put(server, builder);
+        builder = builders.computeIfPresent(server, (key, value) -> value);
+        if (builder != null) {
+            return builder;
         }
-        return builder;
+        String serverHome = server.getServerHome();
+        return builders.computeIfAbsent(server, key -> 
+                new ConfigBuilder(config, serverHome, serverHome, serverHome));

Review Comment:
   The `computeIfPresent` implementation from `ConcurrentHashMap` synchronize at a node level (`Node<K,V>`).  I use `computeIfPresent` to circumvent the need of synchronize the entire map. It does work like a `get()` (`get()` does not synchronize) and it does not have the `@Deprecated` as of now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists