You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/25 16:25:31 UTC
[GitHub] [hadoop-ozone] smengcl opened a new pull request #721: HDDS-3279.
Rebase OFS branch
smengcl opened a new pull request #721: HDDS-3279. Rebase OFS branch
URL: https://github.com/apache/hadoop-ozone/pull/721
## What changes were proposed in this pull request?
Merge commits on master branch to OFS dev branch: `git merge master`
Also need to manually apply a couple of changes in master branch to OFS classes:
- HDDS-3049
- HDDS-2914 (HDDS-2188)
- HDDS-3065
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3279
## How was this patch tested?
- [x] Compile passed with `mvn clean install -Pdist -DskipTests -e -Dmaven.javadoc.skip=true -DskipShade`
- [ ] Ran `TestRootedOzoneFileSystem` and passed locally.
- [ ] Test OFS manually in shell.
## NOTE
DO NOT MERGE this PR from Github. Because merging from Github will squash the merged commits from master branch. This PR is for review and discussion purpose only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on issue #721: HDDS-3279. Rebase
OFS branch
Posted by GitBox <gi...@apache.org>.
smengcl commented on issue #721: HDDS-3279. Rebase OFS branch
URL: https://github.com/apache/hadoop-ozone/pull/721#issuecomment-603999618
Test failure assessment:
- acceptance failure is from smoketest `ozonesecure-mr-mapreduce`. I recall witnessing the same failure before but not doing anything to fix it - possibly a flaky one.
- it-filesystem failure simply results from some tests skipped because of the acceptance failure it seems.
```
[INFO] Results:
[INFO]
[INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Skipping Apache Hadoop Ozone Mini Ozone Chaos Tests
[INFO] This project has been banned from the build due to previous failures.
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Hadoop Ozone Integration Tests 0.5.0-SNAPSHOT:
[INFO]
[INFO] Apache Hadoop Ozone Integration Tests .............. FAILURE [25:14 min]
```
Retriggering the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl closed pull request #721: HDDS-3279. Rebase
OFS branch
Posted by GitBox <gi...@apache.org>.
smengcl closed pull request #721: HDDS-3279. Rebase OFS branch
URL: https://github.com/apache/hadoop-ozone/pull/721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] jojochuang commented on issue #721: HDDS-3279.
Rebase OFS branch
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #721: HDDS-3279. Rebase OFS branch
URL: https://github.com/apache/hadoop-ozone/pull/721#issuecomment-603983510
You actually don't need to submit a PR. Simply git pull --rebase, and then git push -f to force push the branch. But good to see additional check after the rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #721: HDDS-3279. Rebase
OFS branch
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #721: HDDS-3279. Rebase OFS branch
URL: https://github.com/apache/hadoop-ozone/pull/721#issuecomment-604791737
+1. Please go ahead push the change **outside github as Squash and merge is the only option with github.**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl edited a comment on issue #721: HDDS-3279.
Rebase OFS branch
Posted by GitBox <gi...@apache.org>.
smengcl edited a comment on issue #721: HDDS-3279. Rebase OFS branch
URL: https://github.com/apache/hadoop-ozone/pull/721#issuecomment-603999618
Test failure assessment:
- acceptance failure is from smoketest `ozonesecure-mr-mapreduce`. I recall witnessing the same failure before but not doing anything to fix it - possibly a flaky one.
- it-filesystem failure ~~simply results from some tests skipped because of the acceptance failure it seems.~~ ~~seems related to TestOzoneFileInterfaces. Looking into it.~~ `TestOzoneFileInterfaces` passed locally. Might be flaky.
```
[INFO] Results:
[INFO]
[INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Skipping Apache Hadoop Ozone Mini Ozone Chaos Tests
[INFO] This project has been banned from the build due to previous failures.
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Hadoop Ozone Integration Tests 0.5.0-SNAPSHOT:
[INFO]
[INFO] Apache Hadoop Ozone Integration Tests .............. FAILURE [25:14 min]
```
Retriggering the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on issue #721: HDDS-3279. Rebase
OFS branch
Posted by GitBox <gi...@apache.org>.
smengcl commented on issue #721: HDDS-3279. Rebase OFS branch
URL: https://github.com/apache/hadoop-ozone/pull/721#issuecomment-605136056
Thanks @xiaoyuyao . I am going to do the following:
1. Close this PR;
2. Merge master commits to OFS dev branch manually;
3. Create a new PR with only the 3 commits I posted in this PR already;
4. Merge that new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl edited a comment on issue #721: HDDS-3279.
Rebase OFS branch (Draft)
Posted by GitBox <gi...@apache.org>.
smengcl edited a comment on issue #721: HDDS-3279. Rebase OFS branch (Draft)
URL: https://github.com/apache/hadoop-ozone/pull/721#issuecomment-605136056
Thanks @xiaoyuyao . I am going to do the following:
1. Close this PR;
2. Merge master commits to OFS dev branch manually;
3. Create a new PR https://github.com/apache/hadoop-ozone/pull/731 with only the 3 commits I posted in this PR already;
4. Merge that new PR https://github.com/apache/hadoop-ozone/pull/731.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl edited a comment on issue #721: HDDS-3279.
Rebase OFS branch
Posted by GitBox <gi...@apache.org>.
smengcl edited a comment on issue #721: HDDS-3279. Rebase OFS branch
URL: https://github.com/apache/hadoop-ozone/pull/721#issuecomment-603999618
Test failure assessment:
- acceptance failure is from smoketest `ozonesecure-mr-mapreduce`. I recall witnessing the same failure before but not doing anything to fix it - possibly a flaky one.
- it-filesystem failure ~~simply results from some tests skipped because of the acceptance failure it seems. ~~ seems related to TestOzoneFileInterfaces. Looking into it.
```
[INFO] Results:
[INFO]
[INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Skipping Apache Hadoop Ozone Mini Ozone Chaos Tests
[INFO] This project has been banned from the build due to previous failures.
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Hadoop Ozone Integration Tests 0.5.0-SNAPSHOT:
[INFO]
[INFO] Apache Hadoop Ozone Integration Tests .............. FAILURE [25:14 min]
```
Retriggering the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on issue #721: HDDS-3279. Rebase
OFS branch
Posted by GitBox <gi...@apache.org>.
smengcl commented on issue #721: HDDS-3279. Rebase OFS branch
URL: https://github.com/apache/hadoop-ozone/pull/721#issuecomment-603995561
> You actually don't need to submit a PR. Simply git pull --rebase, and then git push -f to force push the branch. But good to see additional check after the rebase.
Yep the way you mentioned (pull rebase + force push) is my preferred way to do a rebase. Thanks for the tip nevertheless.
Since Xiaoyu and I were already using `git merge` previously I think I'd keep it consistent for this dev branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org